Hostname on macOS is not fully qualified

[DerAndereAndi]

The hostname on macOS does not get the required . appended.

[DerAndereAndi]

A fix could look like this:

Issue: On macOS, os.Hostname() returns hostname with .local suffix (e.g., MacBookPro16.local). The Register function checks if hostname has the domain suffix and skips adding the trailing dot, but DNS requires fully qualified domain names to end with a dot.

Location: server.go lines 97-99 and 150-152

Current code:

if !strings.HasSuffix(trimDot(entry.HostName), entry.Domain) {
    entry.HostName = fmt.Sprintf("%s.%s.", trimDot(entry.HostName), trimDot(entry.Domain))
}

Problem: When hostname is MacBookPro16.local and domain is local:

• trimDot("MacBookPro16.local") = "MacBookPro16.local"
• Check: Does "MacBookPro16.local" have suffix "local"? YES
• So the trailing dot is NOT added
• Result: hostname stays as MacBookPro16.local without trailing dot

Error message:

zeroconf: failed to send probe: failed to pack msg ... : dns: domain must be fully qualified

Fix: After the existing check, ensure hostname always ends with a dot:

if !strings.HasSuffix(trimDot(entry.HostName), entry.Domain) {
    entry.HostName = fmt.Sprintf("%s.%s.", trimDot(entry.HostName), trimDot(entry.Domain))
}
// Ensure trailing dot for FQDN
if !strings.HasSuffix(entry.HostName, ".") {
    entry.HostName = entry.HostName + "."
}

This fix needs to be applied in both Register and RegisterProxy functions.