Add ADGUARD_HOME_LOG_TO_STDOUT to log to stdout#8309
Open
lzap wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
everywhere in the codebase, it is stated that when no logging file is given, it logs to stdout. The thing is that is not the case, see, in Go the default behavior is to log to stderr and this is exactly what AdGuard Home does. There is a reason for that behavior and that is in UNIX all logging or debugging output should really go to stderr. So one can argue all is good, change all those comments and everyone is happy.
Well, thing is, I use AdGuard in podman where stdout/stderr is forwarded into journald as info/err and I have all info/debug lines in red on my systems which is driving me crazy. For the record, I documented my podman setup in here: https://lukas.zapletalovi.com/posts/2025/deploy-adguard-via-quadlets/
Here is how it looks like, note the PRIORITY column:
Now, to change the default behavior from stderr to stdout would be too disturbing, I get this. This is why I propose to introduce an environment variable which podman users can set and mitigate this behavior. Alternatively, a config option could be added too if this is what you want.
Cheers.