Convert build time instrumentation plugin from Groovy to Kotlin#10727
Draft
Convert build time instrumentation plugin from Groovy to Kotlin#10727
Conversation
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 68 metrics, 3 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~6830bf690c, baseline=1.61.0-SNAPSHOT~cf6146b8f2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.074 s) : 0, 1074392
Total [baseline] (8.938 s) : 0, 8937981
Agent [candidate] (1.057 s) : 0, 1057163
Total [candidate] (8.83 s) : 0, 8829836
section iast
Agent [baseline] (1.226 s) : 0, 1226392
Total [baseline] (9.564 s) : 0, 9563856
Agent [candidate] (1.228 s) : 0, 1227958
Total [candidate] (9.573 s) : 0, 9573090
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~6830bf690c, baseline=1.61.0-SNAPSHOT~cf6146b8f2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.222 ms) : 0, 1222
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (637.363 ms) : 0, 637363
BytebuddyAgent [candidate] (628.822 ms) : 0, 628822
AgentMeter [baseline] (29.504 ms) : 0, 29504
AgentMeter [candidate] (29.14 ms) : 0, 29140
GlobalTracer [baseline] (260.102 ms) : 0, 260102
GlobalTracer [candidate] (257.449 ms) : 0, 257449
AppSec [baseline] (31.972 ms) : 0, 31972
AppSec [candidate] (31.438 ms) : 0, 31438
Debugger [baseline] (59.773 ms) : 0, 59773
Debugger [candidate] (58.859 ms) : 0, 58859
Remote Config [baseline] (595.241 µs) : 0, 595
Remote Config [candidate] (589.796 µs) : 0, 590
Telemetry [baseline] (8.738 ms) : 0, 8738
Telemetry [candidate] (8.657 ms) : 0, 8657
Flare Poller [baseline] (8.778 ms) : 0, 8778
Flare Poller [candidate] (4.968 ms) : 0, 4968
section iast
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.204 ms) : 0, 1204
BytebuddyAgent [baseline] (794.957 ms) : 0, 794957
BytebuddyAgent [candidate] (797.261 ms) : 0, 797261
AgentMeter [baseline] (11.3 ms) : 0, 11300
AgentMeter [candidate] (11.345 ms) : 0, 11345
GlobalTracer [baseline] (247.63 ms) : 0, 247630
GlobalTracer [candidate] (247.775 ms) : 0, 247775
AppSec [baseline] (26.385 ms) : 0, 26385
AppSec [candidate] (26.317 ms) : 0, 26317
Debugger [baseline] (63.126 ms) : 0, 63126
Debugger [candidate] (62.577 ms) : 0, 62577
Remote Config [baseline] (535.622 µs) : 0, 536
Remote Config [candidate] (531.159 µs) : 0, 531
Telemetry [baseline] (15.049 ms) : 0, 15049
Telemetry [candidate] (14.785 ms) : 0, 14785
Flare Poller [baseline] (4.913 ms) : 0, 4913
Flare Poller [candidate] (4.871 ms) : 0, 4871
IAST [baseline] (25.215 ms) : 0, 25215
IAST [candidate] (25.172 ms) : 0, 25172
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~6830bf690c, baseline=1.61.0-SNAPSHOT~cf6146b8f2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060917
Total [baseline] (11.06 s) : 0, 11060402
Agent [candidate] (1.06 s) : 0, 1059929
Total [candidate] (10.99 s) : 0, 10990287
section appsec
Agent [baseline] (1.263 s) : 0, 1263364
Total [baseline] (11.261 s) : 0, 11260855
Agent [candidate] (1.248 s) : 0, 1248407
Total [candidate] (11.2 s) : 0, 11199721
section iast
Agent [baseline] (1.229 s) : 0, 1228801
Total [baseline] (11.323 s) : 0, 11323104
Agent [candidate] (1.228 s) : 0, 1227902
Total [candidate] (11.366 s) : 0, 11366291
section profiling
Agent [baseline] (1.184 s) : 0, 1183887
Total [baseline] (11.194 s) : 0, 11193940
Agent [candidate] (1.182 s) : 0, 1181975
Total [candidate] (11.109 s) : 0, 11108531
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~6830bf690c, baseline=1.61.0-SNAPSHOT~cf6146b8f2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.207 ms) : 0, 1207
BytebuddyAgent [baseline] (629.565 ms) : 0, 629565
BytebuddyAgent [candidate] (628.409 ms) : 0, 628409
AgentMeter [baseline] (29.149 ms) : 0, 29149
AgentMeter [candidate] (29.227 ms) : 0, 29227
GlobalTracer [baseline] (257.604 ms) : 0, 257604
GlobalTracer [candidate] (257.275 ms) : 0, 257275
AppSec [baseline] (31.422 ms) : 0, 31422
AppSec [candidate] (31.438 ms) : 0, 31438
Debugger [baseline] (59.332 ms) : 0, 59332
Debugger [candidate] (59.174 ms) : 0, 59174
Remote Config [baseline] (588.182 µs) : 0, 588
Remote Config [candidate] (577.874 µs) : 0, 578
Telemetry [baseline] (8.688 ms) : 0, 8688
Telemetry [candidate] (8.617 ms) : 0, 8617
Flare Poller [baseline] (7.246 ms) : 0, 7246
Flare Poller [candidate] (7.909 ms) : 0, 7909
section appsec
crashtracking [baseline] (1.209 ms) : 0, 1209
crashtracking [candidate] (1.204 ms) : 0, 1204
BytebuddyAgent [baseline] (668.247 ms) : 0, 668247
BytebuddyAgent [candidate] (659.023 ms) : 0, 659023
AgentMeter [baseline] (12.215 ms) : 0, 12215
AgentMeter [candidate] (12.086 ms) : 0, 12086
GlobalTracer [baseline] (261.62 ms) : 0, 261620
GlobalTracer [candidate] (258.869 ms) : 0, 258869
IAST [baseline] (24.272 ms) : 0, 24272
IAST [candidate] (23.949 ms) : 0, 23949
AppSec [baseline] (179.026 ms) : 0, 179026
AppSec [candidate] (177.937 ms) : 0, 177937
Debugger [baseline] (66.766 ms) : 0, 66766
Debugger [candidate] (65.722 ms) : 0, 65722
Remote Config [baseline] (589.483 µs) : 0, 589
Remote Config [candidate] (565.529 µs) : 0, 566
Telemetry [baseline] (9.13 ms) : 0, 9130
Telemetry [candidate] (9.044 ms) : 0, 9044
Flare Poller [baseline] (3.682 ms) : 0, 3682
Flare Poller [candidate] (3.606 ms) : 0, 3606
section iast
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (797.066 ms) : 0, 797066
BytebuddyAgent [candidate] (796.237 ms) : 0, 796237
AgentMeter [baseline] (11.356 ms) : 0, 11356
AgentMeter [candidate] (11.351 ms) : 0, 11351
GlobalTracer [baseline] (247.747 ms) : 0, 247747
GlobalTracer [candidate] (247.579 ms) : 0, 247579
IAST [baseline] (25.124 ms) : 0, 25124
IAST [candidate] (25.145 ms) : 0, 25145
AppSec [baseline] (26.322 ms) : 0, 26322
AppSec [candidate] (26.366 ms) : 0, 26366
Debugger [baseline] (63.759 ms) : 0, 63759
Debugger [candidate] (63.66 ms) : 0, 63660
Remote Config [baseline] (526.694 µs) : 0, 527
Remote Config [candidate] (521.251 µs) : 0, 521
Telemetry [baseline] (14.752 ms) : 0, 14752
Telemetry [candidate] (14.858 ms) : 0, 14858
Flare Poller [baseline] (4.872 ms) : 0, 4872
Flare Poller [candidate] (4.933 ms) : 0, 4933
section profiling
crashtracking [baseline] (1.173 ms) : 0, 1173
crashtracking [candidate] (1.163 ms) : 0, 1163
BytebuddyAgent [baseline] (683.662 ms) : 0, 683662
BytebuddyAgent [candidate] (683.79 ms) : 0, 683790
AgentMeter [baseline] (8.6 ms) : 0, 8600
AgentMeter [candidate] (8.567 ms) : 0, 8567
GlobalTracer [baseline] (215.793 ms) : 0, 215793
GlobalTracer [candidate] (215.135 ms) : 0, 215135
AppSec [baseline] (31.831 ms) : 0, 31831
AppSec [candidate] (31.805 ms) : 0, 31805
Debugger [baseline] (65.278 ms) : 0, 65278
Debugger [candidate] (62.589 ms) : 0, 62589
Remote Config [baseline] (580.34 µs) : 0, 580
Remote Config [candidate] (574.723 µs) : 0, 575
Telemetry [baseline] (8.142 ms) : 0, 8142
Telemetry [candidate] (10.49 ms) : 0, 10490
Flare Poller [baseline] (3.512 ms) : 0, 3512
Flare Poller [candidate] (3.492 ms) : 0, 3492
ProfilingAgent [baseline] (94.255 ms) : 0, 94255
ProfilingAgent [candidate] (93.577 ms) : 0, 93577
Profiling [baseline] (94.837 ms) : 0, 94837
Profiling [candidate] (94.131 ms) : 0, 94131
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 19 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~6830bf690c, baseline=1.61.0-SNAPSHOT~cf6146b8f2
dateFormat X
axisFormat %s
section baseline
no_agent (19.412 ms) : 19213, 19612
. : milestone, 19412,
appsec (18.999 ms) : 18807, 19192
. : milestone, 18999,
code_origins (17.855 ms) : 17680, 18031
. : milestone, 17855,
iast (17.977 ms) : 17799, 18156
. : milestone, 17977,
profiling (18.658 ms) : 18474, 18843
. : milestone, 18658,
tracing (17.819 ms) : 17645, 17994
. : milestone, 17819,
section candidate
no_agent (19.109 ms) : 18916, 19303
. : milestone, 19109,
appsec (18.662 ms) : 18474, 18851
. : milestone, 18662,
code_origins (18.015 ms) : 17836, 18194
. : milestone, 18015,
iast (17.631 ms) : 17460, 17803
. : milestone, 17631,
profiling (19.732 ms) : 19533, 19932
. : milestone, 19732,
tracing (17.71 ms) : 17535, 17886
. : milestone, 17710,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~6830bf690c, baseline=1.61.0-SNAPSHOT~cf6146b8f2
dateFormat X
axisFormat %s
section baseline
no_agent (1.164 ms) : 1153, 1175
. : milestone, 1164,
iast (3.391 ms) : 3343, 3438
. : milestone, 3391,
iast_FULL (5.889 ms) : 5831, 5948
. : milestone, 5889,
iast_GLOBAL (3.535 ms) : 3487, 3583
. : milestone, 3535,
profiling (2.136 ms) : 2117, 2155
. : milestone, 2136,
tracing (1.84 ms) : 1822, 1858
. : milestone, 1840,
section candidate
no_agent (1.196 ms) : 1184, 1208
. : milestone, 1196,
iast (3.248 ms) : 3200, 3295
. : milestone, 3248,
iast_FULL (5.843 ms) : 5784, 5902
. : milestone, 5843,
iast_GLOBAL (3.532 ms) : 3489, 3575
. : milestone, 3532,
profiling (2.079 ms) : 2058, 2100
. : milestone, 2079,
tracing (1.798 ms) : 1783, 1813
. : milestone, 1798,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~6830bf690c, baseline=1.61.0-SNAPSHOT~cf6146b8f2
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (2.525 ms) : 2470, 2580
. : milestone, 2525,
iast (2.264 ms) : 2194, 2333
. : milestone, 2264,
iast_GLOBAL (2.305 ms) : 2235, 2375
. : milestone, 2305,
profiling (2.127 ms) : 2070, 2184
. : milestone, 2127,
tracing (2.075 ms) : 2021, 2129
. : milestone, 2075,
section candidate
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (3.811 ms) : 3589, 4033
. : milestone, 3811,
iast (2.262 ms) : 2193, 2331
. : milestone, 2262,
iast_GLOBAL (2.303 ms) : 2233, 2372
. : milestone, 2303,
profiling (2.103 ms) : 2047, 2159
. : milestone, 2103,
tracing (2.087 ms) : 2033, 2142
. : milestone, 2087,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~6830bf690c, baseline=1.61.0-SNAPSHOT~cf6146b8f2
dateFormat X
axisFormat %s
section baseline
no_agent (15.085 s) : 15085000, 15085000
. : milestone, 15085000,
appsec (14.872 s) : 14872000, 14872000
. : milestone, 14872000,
iast (18.126 s) : 18126000, 18126000
. : milestone, 18126000,
iast_GLOBAL (17.794 s) : 17794000, 17794000
. : milestone, 17794000,
profiling (14.836 s) : 14836000, 14836000
. : milestone, 14836000,
tracing (15.237 s) : 15237000, 15237000
. : milestone, 15237000,
section candidate
no_agent (15.232 s) : 15232000, 15232000
. : milestone, 15232000,
appsec (14.881 s) : 14881000, 14881000
. : milestone, 14881000,
iast (17.895 s) : 17895000, 17895000
. : milestone, 17895000,
iast_GLOBAL (17.896 s) : 17896000, 17896000
. : milestone, 17896000,
profiling (14.806 s) : 14806000, 14806000
. : milestone, 14806000,
tracing (15.153 s) : 15153000, 15153000
. : milestone, 15153000,
|
20edf09 to
6830bf6
Compare
6830bf6 to
9903231
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Improves type safety by converting build time instrumentation plugin to Kotlin.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.