process articles with multiple imprints in preview

[SteffenAstheimer]

This will handle articles with multiple imprints, omit the journal title from the citation and add a list of all journal and issues in which the text was published.

Here an example:

And one example where we even have links to the texts and might think about adding the links to the actual issue titles in the future:

[peterstadler]

I'm not sure whether this is really what we want since this will only work for journal citations (in general) when used with the preview-biblio.html where the missing imprints are output.
All other calls to this function (e.g. from letter editorials) will have empty imprints.
I know this is tricky to solve, I just wanted to make sure about the consequences …

[SteffenAstheimer]

Yeah, that's definitely a catch. I guess so far it works, since we only have multiple imprints in our bibliography data, and nowhere else. But in theory it should be allowed elsewhere.

We could call the new helper function bibl:printJournalCitationsByImprint from within document.html where the sources are created. This is the only other place where we might want to display multiple imprints that I can think of (apart from the not yet existing single view html page):

WeGA-WebApp/templates/document.html

Lines 226 to 230 in 6365337

	<div data-template="app:textSources">
	<h3 class="media-heading">
	<span data-template="lang:translate">tradition</span>
	<em class="small" data-template="app-shared:print" data-template-key="textSourcesCountString"/>
	</h3>

[SteffenAstheimer]

How about this:

1. We return to having one bibl:printJournalCitation() function which handles all occurrences of journal citations, both with single or multiple imprints. Handling multiple imprints should be seen as fallback behaviour. All imprints simply get concatenated and the whole journal citation is classified with a "deleteme" class (for step 2):

WeGA-WebApp/modules/bibl.xqm

Lines 177 to 193 in c77eea0

	declare function bibl:printJournalCitation($monogr as element(tei:monogr), $wrapperElement as element(), $lang as xs:string) as element()? {
	let $journalTitle :=
	if (count($monogr/tei:imprint) gt 1)
	then <xhtml:span class="deleteme_journalTitle">{bibl:printTitles($monogr/tei:title, $monogr/tei:edition)/node()}</xhtml:span>
	else (<xhtml:span class="journalTitle">{bibl:printTitles($monogr/tei:title, $monogr/tei:edition)/node()}</xhtml:span>)
	let $biblScope :=
	if (count($monogr/tei:imprint) gt 1)
	then for $imprint in $monogr/tei:imprint
	return <xhtml:span class="deleteme_imprintSection">{bibl:biblScope($imprint, $lang)}</xhtml:span>
	else <xhtml:span class="imprint">{bibl:biblScope($monogr/tei:imprint, $lang)}</xhtml:span>
	return
	element {$wrapperElement/name()} {
	$wrapperElement/@*,
	$journalTitle,
	$biblScope
	}
	};

2. In app:preview-citation() we erase all deleteme attributes to prevent both journal title and issues to appear in the citation string:

WeGA-WebApp/modules/app.xqm

Lines 1977 to 1989 in c77eea0

	declare
	%templates:default("lang", "en")
	function app:preview-citation($node as node(), $model as map(*), $lang as xs:string) as element(xhtml:p)? {
	let $source := query:get-main-source($model('doc'))
	return
	typeswitch($source)
	case element(tei:biblStruct) return
	element {node-name($node)} {
	$node/@*,
	bibl:printCitation($source, <xhtml:p/>, $lang)/node()[not(self::xhtml:span[@class=('deleteme_journalTitle', 'deleteme_imprintSection')])]
	}
	default return ()
	};

3. We use the bug of leftover "in: " strings as a feature and print all issues of the serial publication as list items without the leading "erschienen in: " header:

Alternatively we could surely get rid of the "in: " and return to having a section header "erschienen in: ".

What do you think, @peterstadler?

[peterstadler]

Hi Steffen, nur ganz kurz, ich schaffe es gerade nicht im Detail durchzugehen, aber mir sind zwei Punkte direkt aufgefallen:

1. Die Idee von mir mit den "deleteme"-CSS-Klassen war doof. Das sollten wir doch besser sinnvoll nennen. Vielleicht durchzählen? imprintSection1 etc?
2. Die XQSuite-Tests failen jetzt
3. die neue Funktion bibl:printJournalCitationPerImprint#3 sollte auch mit Tests versorgt werden.

Vielen Dank aber für die ganzen Ergänzungen!