Skip to content

[Fixes #14339] Drop support Dropbox storage manager#14342

Merged
giohappy merged 1 commit into
masterfrom
ISSUE_14339
Jun 17, 2026
Merged

[Fixes #14339] Drop support Dropbox storage manager#14342
giohappy merged 1 commit into
masterfrom
ISSUE_14339

Conversation

@mattiagiupponi

@mattiagiupponi mattiagiupponi commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Jun 16, 2026
@mattiagiupponi mattiagiupponi linked an issue Jun 16, 2026 that may be closed by this pull request

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the Dropbox storage manager implementation, its associated unit tests, and the 'dropbox' dependency from the project configuration. I have no feedback to provide on these changes.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@mattiagiupponi mattiagiupponi marked this pull request as ready for review June 16, 2026 07:56
@mattiagiupponi mattiagiupponi requested a review from giohappy June 16, 2026 07:56
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.92%. Comparing base (be64508) to head (fdc0d55).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #14342       +/-   ##
===========================================
+ Coverage   34.71%   74.92%   +40.21%     
===========================================
  Files         982      982               
  Lines       60496    60538       +42     
  Branches     8247     8258       +11     
===========================================
+ Hits        21002    45360    +24358     
+ Misses      38332    13348    -24984     
- Partials     1162     1830      +668     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@giohappy giohappy added this to the 5.1.0 milestone Jun 17, 2026
@giohappy giohappy merged commit 6b1d8db into master Jun 17, 2026
28 checks passed
@giohappy giohappy deleted the ISSUE_14339 branch June 17, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 5.1.x cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop the support for Dropbox storage

2 participants