Skip to content

[Core] Fix the issues in BinaryPacket.GrowSize #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Executor-Cheng wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −4
Open

[Core] Fix the issues in BinaryPacket.GrowSize #910

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions Lagrange.Core/Utility/Binary/BinaryPacket.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,12 +292,17 @@ private void Increment(int count)
[MethodImpl(MethodImplOptions.NoInlining)] // NoInlining is used to prevent the method from being inlined as it is not used frequently
private void GrowSize(int additional)
{
while (_offset + additional > _capacity) _capacity *= 2;
_bytesToReturnToPool = ArrayPool<byte>.Shared.Rent(_capacity);
int requested = _offset + additional;
int desired = (int)BitOperations.RoundUpToPowerOf2((uint)requested);
int capacity = desired > requested ? desired : requested;
Comment on lines 293 to +297

_span[.._offset].CopyTo(_bytesToReturnToPool.AsSpan());
var rent = ArrayPool<byte>.Shared.Rent(capacity);
_span[.._offset].CopyTo(rent.AsSpan());
if (_bytesToReturnToPool != null) ArrayPool<byte>.Shared.Return(_bytesToReturnToPool);
_capacity = capacity;
_bytesToReturnToPool = rent;

_span = _bytesToReturnToPool.AsSpan();
_span = rent.AsSpan();
_buffer = ref Unsafe.Add(ref MemoryMarshal.GetReference(_span), _offset);
}

Expand Down
Loading