fix(web): prefix non-built-in session skills with skill: in slash menu#1060
Open
djfch wants to merge 3 commits into
Open
fix(web): prefix non-built-in session skills with skill: in slash menu#1060djfch wants to merge 3 commits into
djfch wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: 4fe8cc5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8720d9076c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
djfch
force-pushed
the
fix/web-skill-slash-prefix
branch
from
8720d90 to
ee1ec54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
N/A — direct UX inconsistency report.
Problem
In the web UI, typing
/skillin the composer only showed skills whose names happened to contain the substring "skill". In the CLI/TUI, the same query lists every non-built-in session skill because they are rendered as/skill:<name>. This made the web slash menu appear to have far fewer skills than the CLI.What changed
apps/kimi-web/src/lib/slashCommands.tsso that session skills with a non-builtinsource are shown as/skill:<name>, matching the TUI behavior. Built-in skills still render as/<name>.apps/kimi-web/test/slash-menu.test.tsto cover both built-in and non-built-in skill slash names, and to verify that/skillfilters the full non-built-in skill list.@moonshot-ai/kimi-code.Checklist
gen-changesetsskill.gen-docsskill — no user-facing doc update needed for this minor UI consistency fix.