Fix mysql initial setup in docker#47
Merged
kabili207 merged 1 commit intoJul 16, 2026
Merged
Conversation
MySQL 8.4 rejects nullable PRIMARY KEY columns. Several primary key columns in the initial schema were missing 'null' => false: user_id on sys_email_change and sys_password_reset, the composite keys on the battle tower and ranking tables, bxt_ranking_categories.id, and amkj_user_map.player_id. Add it so the schema migrates on a fresh database.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
docker-compose.example.ymlpinsmysql:8.4.0, which rejects nullablePRIMARY KEYcolumns (ERROR 1171: All parts of a PRIMARY KEY must be NOT NULL). Several non-identity primary key columns in the initial schema are declared without'null' => false, so a freshdocker compose upfails during migration before any tables are usable.Change
Adds
'null' => falseto the affected primary key columns:user_idonsys_email_changeandsys_password_reset, the composite keys on the per-region*_battle_tower_trainersand*_rankingtables,bxt_ranking_categories.id, andamkj_user_map.player_id. Identity (auto-increment) columns are already NOT NULL and are left unchanged.Testing
Ran the migration against stock
mysql:8.4.0(no overrides). It previously failed on the firstCREATE TABLE; with this change it completes all migrations and the containers come up.