Adds lazy loading + streaming queue population for minitest-queue#375
Open
danielahrnsbrak wants to merge 2 commits intomainfrom
Open
Adds lazy loading + streaming queue population for minitest-queue#375danielahrnsbrak wants to merge 2 commits intomainfrom
danielahrnsbrak wants to merge 2 commits intomainfrom
Conversation
danielahrnsbrak
force-pushed
the
danielahrnsbrak/lazy-loading-and-streaming
branch
from
b4e596a to
8fe8edd
Compare
danielahrnsbrak
force-pushed
the
danielahrnsbrak/lazy-loading-and-streaming
branch
from
8fe8edd to
41ab5d8
Compare
…mes for minitest-queue - Lazy loading: test files are loaded on-demand instead of all upfront, reducing worker memory - Streaming population: leader streams test entries to Redis in batches so workers can start immediately - Preresolved test names: pre-computed test lists can be streamed directly without file discovery - Reconciliation: --test-files combined with --preresolved-tests re-discovers changed files - Configurable stale entry handling: CI_QUEUE_SKIP_STALE_TESTS skips missing methods gracefully - FileLoader, ClassResolver, QueueEntry, LazyEntryResolver, LazyTestDiscovery infrastructure - Worker profile reporting for observability
danielahrnsbrak
force-pushed
the
danielahrnsbrak/lazy-loading-and-streaming
branch
from
2f9f5cc to
9b6e64e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds lazy loading + streaming queue population for
minitest-queueto improve startup behavior and memory profile for large suites, while keeping existing eager mode intact.What changed
test_id+ metadata), and updated Redis Lua scripts to operate on entry payloads safely.ClassResolverFileLoaderQueueEntryLazyEntryResolverLazyTestDiscoverystream_populatesupportstreaming/ready)--lazy-load--lazy-load-stream-batch-size--lazy-load-stream-timeout--test-filesCI_QUEUE_LAZY_LOAD_TEST_HELPERSminitest-queue(notrspec-queue).Why
Large test suites pay a high boot cost when every worker eagerly loads all test files.
This change allows:
--test-files).Test plan
bundle exec rake test195 tests, 642 assertions, 0 failures, 0 errors, 0 skipsNotes