Make okta and jamf properties snake_case#324
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (31)
WalkthroughJamf and Okta documentation now uses snake_case property names in node tables and sample YAML, and the Jamf/Okta queries now reference the renamed properties. ChangesJamf and Okta snake_case doc sync
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
JonasBK
added
the
opengraph
jeff-matthews
approved these changes
Jun 25, 2026
jeff-matthews
left a comment
jeff-matthews
left a comment
Contributor
There was a problem hiding this comment.
Looks good @JonasBK! Thanks for the PR. Is it ok to merge and publish right away?
Contributor
Author
|
@jeff-matthews, yup! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first iteration of the OG collectors for Okta and Jamf created properties in camelCase. OpenHound use snake_case. This PR will align with OpenHound.
Summary by CodeRabbit
snake_caseproperty names across node tables and sample values.tier,site_id,okta_domain, and other renamed fields.