Make List + add a single undo step without rid alias#70
Merged
VPDPersonal merged 1 commit intoJun 23, 2026
Merged
Conversation
VPDPersonal
added
type: fix
VPDPersonal
merged commit 099e176
into
feature/serialize-reference-dropdown
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
+add on aList<[SerializeReference]>a single Undo step by growing the array and assigning the fresh instance before oneApplyModifiedProperties(), instead of applying twice.arraySize++within the same modification, so no rid-aliased duplicate is left behind.Notes for review
ApplyModifiedProperties()/Update();SetManagedReferenceAndApplyis nowSetManagedReferenceplus the single trailing apply. One Ctrl+Z now reverts the whole add, matching native add semantics.Linked issues
Refs #49 - addresses review finding #49 (comment)