Adding support for PostgreSQL's XML functions#2252
Open
LucaCappelletti94 wants to merge 3 commits intoapache:mainfrom
Open
Adding support for PostgreSQL's XML functions#2252LucaCappelletti94 wants to merge 3 commits intoapache:mainfrom
LucaCappelletti94 wants to merge 3 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds PostgreSQL XML expression support to
sqlparser-rsby introducing dedicated AST variants (Expr::Xml*) and parser paths forXMLCONCAT,XMLELEMENT,XMLFOREST,XMLPARSE,XMLPI,XMLROOT, andXMLSERIALIZE, aligned with PostgreSQL XML function syntax (PostgreSQL XML functions)Implementation is intentionally enabled for both
PostgreSqlDialectandGenericDialect, while non-target dialects keep treatingxml*names as ordinary function identifiers and reject XML-special grammar forms.The test updates explicitly lock these dialect boundaries, add AST-shape coverage for all new XML nodes, and prefer structural assertions over formatting-sensitive string checks.
This PR DOES NOT add support for XML parsing of course, which remains something that the user should validate, since PostgreSQL itself will accept (and fail at runtime) queries with invalid XML. Whether we should raise errors there is debatable.