HDDS-14702. Make lazy source container replica deletion interval configurable#9837
Open
Gargi-jais11 wants to merge 1 commit intoapache:masterfrom
Open
HDDS-14702. Make lazy source container replica deletion interval configurable#9837Gargi-jais11 wants to merge 1 commit intoapache:masterfrom
Gargi-jais11 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@ChenSammi Please review the patch. |
Contributor
sreejasahithi
left a comment
sreejasahithi
left a comment
There was a problem hiding this comment.
Thanks @Gargi-jais11 for working on this.
Comment on lines
+123
to
+125
| description = "The deletion delay after a container is successfully moved from source volume to " + | ||
| "destination volume before the source container replica is deleted. " + | ||
| "Unit could be defined with postfix (ns,ms,s,m,h,d).") |
Contributor
There was a problem hiding this comment.
The word "deletion" sounds redundant here.
Suggested change
| description = "The deletion delay after a container is successfully moved from source volume to " + | |
| "destination volume before the source container replica is deleted. " + | |
| "Unit could be defined with postfix (ns,ms,s,m,h,d).") | |
| description = "The delay after a container is successfully moved from source volume to " + | |
| "destination volume before the source container replica is deleted. " + | |
| "Unit could be defined with postfix (ns,ms,s,m,h,d).") |
| | `hdds.datanode.disk.balancer.parallel.thread` | `5` | The number of worker threads to use for moving containers in parallel. | | ||
| | `hdds.datanode.disk.balancer.service.interval` | `60s` | The time interval at which the Datanode DiskBalancer service checks for imbalance and updates its configuration. | | ||
| | `hdds.datanode.disk.balancer.stop.after.disk.even` | `true` | If true, the DiskBalancer will automatically stop its balancing activity once disks are considered balanced (i.e., all volume densities are within the threshold). | | ||
| | `hdds.datanode.disk.balancer.replica.deletion.delay` | `5m` | The deletion delay after a container is successfully moved from source volume to destination volume before the source container replica is deleted. This lazy deletion allows time before failing the read thread holding the old container replica. Unit: ns, ms, s, m, h, d. | |
Contributor
There was a problem hiding this comment.
Suggested change
| | `hdds.datanode.disk.balancer.replica.deletion.delay` | `5m` | The deletion delay after a container is successfully moved from source volume to destination volume before the source container replica is deleted. This lazy deletion allows time before failing the read thread holding the old container replica. Unit: ns, ms, s, m, h, d. | | |
| | `hdds.datanode.disk.balancer.replica.deletion.delay` | `5m` | The delay after a container is successfully moved from source volume to destination volume before the source container replica is deleted. This lazy deletion provides a grace period before failing the read thread holding the old container replica. Unit: ns, ms, s, m, h, d. | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently source container replica deletion is postponed by 1 hour after the container is successfully moved from source volume to destination volume during disk balancing.
This PR aims to make this configurable, and reduce the default value from 1 hour to 5 minutes.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14702
How was this patch tested?
Passed existing test cases for replica deletion delay.