refactor: consolidate empty-string env-var validators in Configuration#965
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #965 +/- ##
==========================================
+ Coverage 89.90% 90.33% +0.42%
==========================================
Files 49 49
Lines 3091 3093 +2
==========================================
+ Hits 2779 2794 +15
+ Misses 312 299 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Pijukatel
reviewed
Jun 12, 2026
5cc2a2a to
6c90a1d
Compare
Pijukatel
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A few
Configurationfields were already guarded against empty-string env vars with ad-hocBeforeValidatorlambdas. The Apify platform sometimes sets an env var to an empty string instead of leaving it unset (see #303, or this Discord thread), and for these fields''cannot be parsed into the target type, so without the guard validation would raise and crashActor.init().This PR is a pure refactor: it consolidates those repeated lambdas into a single shared
_default_if_empty(default=...)validator. There is no behavior change, and the empty-string handling is not extended to any new fields.Changes
_default_if_empty(default=...)validator.'':max_paid_dataset_items(→None)max_total_charge_usd(→None)timeout_at(→None)user_is_paying(→False)