fix: correct reclaim_request count adjustment for already-handled requests#973
Open
vdusek wants to merge 5 commits into
Open
fix: correct reclaim_request count adjustment for already-handled requests#973vdusek wants to merge 5 commits into
vdusek wants to merge 5 commits into
Conversation
vdusek
added
adhoc
github-actions
Bot
added
the
tested
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #973 +/- ##
==========================================
+ Coverage 89.90% 90.10% +0.19%
==========================================
Files 49 49
Lines 3091 3091
==========================================
+ Hits 2779 2785 +6
+ Misses 312 306 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
changed the title
…t-returns-handled-requests # Conflicts: # tests/unit/storage_clients/test_apify_request_queue_client.py
vdusek
changed the title
vdusek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix handled/pending count drift when reclaiming an already-handled request in the Apify request queue clients (single and shared modes).
When a previously handled request is reclaimed, it must move back from handled to pending in the queue metadata. The counter adjustment now keys off the platform's
update_requestresponse: on a PUT,wasAlreadyHandledreports the request's state before the update (verified against the real API), so handled is decremented and pending incremented exactly whenprocessed_request.was_already_handledisTrue. This mirrorsmark_request_as_handled, which increments on the inverse condition.Covered by an integration test parametrized over single/shared modes that verifies the real handled→pending transition.