Skip to content

πŸš€ kiali: Update includeAmbient from Kiali refactorΒ #9694

Description

@josunect

Workspace

Kiali

πŸ”– Feature description

Affected by this kiali change:
kiali/kiali#9936 (review)

Needed changes:

  1. kiali-common/src/types/MetricsOptions.ts β€” Breaking

export interface IstioMetricsOptions extends MetricsQuery {
reporter: Reporter; // ← string
includeAmbient?: boolean; // ← REmove
}
export type Reporter = 'source' | 'destination' | 'both'; // ← Remove
2. kiali/src/services/Api.ts β€” Breaking funcional
Lines 730-732: still pass includeAmbient=true to the backend, but the backend is not accepting this. Even if won't give a 400 (Just will be ignored), metrics won't be included. Logic should be moved to reporter=source,waypoint.

  1. kiali/src/components/MetricsOptions/MetricsReporter.tsx β€” TypeScript error
    Will give an error while syncing types with the new Kiali version

  2. kiali/src/components/Metrics/IstioMetrics.tsx β€” TypeScript error
    const onReporterChanged = (reporter: Reporter): void => { // ← Reporter doesn't exist

  3. kiali/src/pages/Overview/OverviewPage.tsx
    Still pass includeAmbient: serverConfig?.ambientEnabled ?? false β€” same than Api.ts.

🎀 Context

Kiali 2.29 version breaking change for Ambient metrics

✌️ Possible Implementation

No response

πŸ‘€ Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

🏒 Have you read the Code of Conduct?

Are you willing to submit PR?

None

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions