Workspace
Kiali
π Feature description
Affected by this kiali change:
kiali/kiali#9936 (review)
Needed changes:
- kiali-common/src/types/MetricsOptions.ts β Breaking
export interface IstioMetricsOptions extends MetricsQuery {
reporter: Reporter; // β string
includeAmbient?: boolean; // β REmove
}
export type Reporter = 'source' | 'destination' | 'both'; // β Remove
2. kiali/src/services/Api.ts β Breaking funcional
Lines 730-732: still pass includeAmbient=true to the backend, but the backend is not accepting this. Even if won't give a 400 (Just will be ignored), metrics won't be included. Logic should be moved to reporter=source,waypoint.
-
kiali/src/components/MetricsOptions/MetricsReporter.tsx β TypeScript error
Will give an error while syncing types with the new Kiali version
-
kiali/src/components/Metrics/IstioMetrics.tsx β TypeScript error
const onReporterChanged = (reporter: Reporter): void => { // β Reporter doesn't exist
-
kiali/src/pages/Overview/OverviewPage.tsx
Still pass includeAmbient: serverConfig?.ambientEnabled ?? false β same than Api.ts.
π€ Context
Kiali 2.29 version breaking change for Ambient metrics
βοΈ Possible Implementation
No response
π Have you spent some time to check if this feature request has been raised before?
π’ Have you read the Code of Conduct?
Are you willing to submit PR?
None
Workspace
Kiali
π Feature description
Affected by this kiali change:
kiali/kiali#9936 (review)
Needed changes:
export interface IstioMetricsOptions extends MetricsQuery {
reporter: Reporter; // β string
includeAmbient?: boolean; // β REmove
}
export type Reporter = 'source' | 'destination' | 'both'; // β Remove
2. kiali/src/services/Api.ts β Breaking funcional
Lines 730-732: still pass includeAmbient=true to the backend, but the backend is not accepting this. Even if won't give a 400 (Just will be ignored), metrics won't be included. Logic should be moved to reporter=source,waypoint.
kiali/src/components/MetricsOptions/MetricsReporter.tsx β TypeScript error
Will give an error while syncing types with the new Kiali version
kiali/src/components/Metrics/IstioMetrics.tsx β TypeScript error
const onReporterChanged = (reporter: Reporter): void => { // β Reporter doesn't exist
kiali/src/pages/Overview/OverviewPage.tsx
Still pass includeAmbient: serverConfig?.ambientEnabled ?? false β same than Api.ts.
π€ Context
Kiali 2.29 version breaking change for Ambient metrics
βοΈ Possible Implementation
No response
π Have you spent some time to check if this feature request has been raised before?
π’ Have you read the Code of Conduct?
Are you willing to submit PR?
None