[ID3v2] Split Frame Factory#139
Open
benrr101 wants to merge 46 commits into
Open
Conversation
…ender methods to the frame header class.
Comment on lines
53
to
+56
| Guards.truthy(header, "header"); | ||
| Guards.byte(version, "version"); | ||
| Guards.truthy(fieldBytes, "fieldBytes"); | ||
| Guards.byte(version, "number"); | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR splits the ID3v2 frame factory code into fromFile and fromRawData (more or less). This includes a large refactoring of the frame construction code. All frame classes now have a
fromFieldBytes(header, fieldBytes, version)method that replacesfromOffsetRawData. The offset wasn't ever very effective, nor was multiple places where headers were being read. Frame extended header fields were moved to the header class as was the extended header reading logic. The tests were completely updated to be waaaaay better.