Skip to content

RowInstance: Fix setting class when there are multiple classes#7293

Open
janezd wants to merge 1 commit into
biolab:masterfrom
janezd:fix-rowinstance-setitem
Open

RowInstance: Fix setting class when there are multiple classes#7293
janezd wants to merge 1 commit into
biolab:masterfrom
janezd:fix-rowinstance-setitem

Conversation

@janezd

@janezd janezd commented Jun 2, 2026

Copy link
Copy Markdown
Contributor
Issue

Fixes #7291.

Description of changes

Do not ignore the class index.

Note: Failed tests are unrelated. (See #7294, which fixes the problem, though not for oldest supported scikit.)

Includes
  • Code changes
  • Tests

@janezd janezd force-pushed the fix-rowinstance-setitem branch from bc67986 to 523bc3d Compare June 19, 2026 18:46
@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.03%. Comparing base (99bb865) to head (523bc3d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7293   +/-   ##
=======================================
  Coverage   89.02%   89.03%           
=======================================
  Files         336      336           
  Lines       74427    74426    -1     
=======================================
+ Hits        66257    66263    +6     
+ Misses       8170     8163    -7     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assignment to one of the class columns modifies all class columns

2 participants