Resolve issue with carriage return breaking whitespace character literals#148
Merged
andrew-davie merged 2 commits intoJul 7, 2026
Conversation
…g_character_literals
Contributor
Author
|
Hi @andrew-davie , when you have a chance, could you review this PR? |
Member
|
Done |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change resolves an issue where a character literal for a space (ASCII 0x20) (such as
LDAA #') followed by a trailing carriage return character (\r, ASCII 0xD), will be encoded incorrectly. The parser treats the trailing \r as the character to encode.