fix: apply tblproperties to metric_view models at create time#1530
Open
sd-db wants to merge 1 commit into
Open
fix: apply tblproperties to metric_view models at create time#1530sd-db wants to merge 1 commit into
sd-db wants to merge 1 commit into
Conversation
The metric_view create branch applied databricks_tags but not tblproperties, so tblproperties configured on a model were dropped on the first build and only applied on a later alter/replace run. Apply them on the create branch, mirroring replace_with_metric_view. Closes #1527
sd-db
force-pushed
the
sd-db/fix/metric-view-tblproperties-on-create
branch
from
e7dbec4 to
19cc61e
Compare
Coverage report
This PR does not seem to contain any modification to coverable code. |
Collaborator
Author
|
/integration-test |
|
Integration tests dispatched for PR #1530 by @sd-db. Track progress in the Actions tab. |
|
Integration results for PR #1530 — UC cluster ✅ success · SQL warehouse ✅ success · All-purpose cluster ❌ failure · Shard coverage ✅ success |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
tblpropertiesconfigured on ametric_viewmodel were not applied on the first build —dbt runreported success but the configured properties were absent from the created view; they only appeared on a later alter/replace run. The create branch of the metric_view materialization applieddatabricks_tagsbut nottblproperties.This applies
tblpropertieson the create branch, mirroring the existingreplace_with_metric_viewpath ({% if tblproperties %}{{ apply_tblproperties(...) }}{% endif %}).Closes #1527
Testing
tests/functional/adapter/metric_views/test_metric_view_materialization.py→ 7 passed (no regression), ondatabricks_uc_sql_endpoint.ruff/ruff format/mypyclean.