Skip to content

chore: Update and add nydus emeritus approvers#147

Open
mingcheng wants to merge 1 commit intomasterfrom
chroe/update-emeritus-approvers
Open

chore: Update and add nydus emeritus approvers#147
mingcheng wants to merge 1 commit intomasterfrom
chroe/update-emeritus-approvers

Conversation

@mingcheng
Copy link
Member

Description

  • Add QinQi Zhai, Shang Zhao, and Yadong Ding to emeritus approvers list
  • Update table formatting for better readability

link with dragonflyoss/nydus#1886

- Add QinQi Zhai, Shang Zhao, and Yadong Ding to emeritus approvers list
- Update table formatting for better readability

Signed-off-by: mingcheng <mingcheng@apache.org>
@mingcheng mingcheng changed the title docs(roles): Add emeritus approvers 📝 chroe: Update and add nydus emeritus approvers Mar 4, 2026
@mingcheng mingcheng marked this pull request as ready for review March 4, 2026 02:06
Copilot AI review requested due to automatic review settings March 4, 2026 02:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Dragonfly community approvers documentation by adding entries and improving table readability (linked to nydus issue #1886).

Changes:

  • Add a new entry to the Current Approvers table.
  • Add three entries to the Emeritus Approvers table.
  • Reformat the emeritus table header/alignment for readability.
Comments suppressed due to low confidence (2)

roles/Approvers.md:19

  • The PR description says it only updates the emeritus approvers list/table formatting, but this change adds a new current approver (Zephyr). If this is unintended, please revert; otherwise, update the PR description/title to reflect adding a current approver as well.
|     [Zephyr](https://github.com/Zephyrcf)     | Changfu Zhang |     zinsist777@gmail.com     | University of Science and Technology Beijing  |

roles/Approvers.md:27

  • This section says the emeritus approvers list is sorted alphabetically by name, but the newly added rows aren’t (e.g., Yadong Ding (D) appears after QinQi Zhai (Q) and Shang Zhao (S)). Please reorder the rows or update the sentence if sorting isn’t required.
Below is the list of emeritus (retired) approvers. Thank them for their contribution to the project. The list is sorted alphabetically by name.

|                   GitHub ID                   |    Name     |              Email              |     Company or Organization     |
| :-------------------------------------------: | :---------: | :-----------------------------: | :-----------------------------: |
| [adamqqqplay](https://github.com/adamqqqplay) | QinQi Zhai  |         adamqqq@163.com         |          Alibaba Group          |

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mingcheng mingcheng changed the title chroe: Update and add nydus emeritus approvers chore: Update and add nydus emeritus approvers Mar 4, 2026
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants