chore: Update and add nydus emeritus approvers#147
Open
Conversation
- Add QinQi Zhai, Shang Zhao, and Yadong Ding to emeritus approvers list - Update table formatting for better readability Signed-off-by: mingcheng <mingcheng@apache.org>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Dragonfly community approvers documentation by adding entries and improving table readability (linked to nydus issue #1886).
Changes:
- Add a new entry to the Current Approvers table.
- Add three entries to the Emeritus Approvers table.
- Reformat the emeritus table header/alignment for readability.
Comments suppressed due to low confidence (2)
roles/Approvers.md:19
- The PR description says it only updates the emeritus approvers list/table formatting, but this change adds a new current approver (Zephyr). If this is unintended, please revert; otherwise, update the PR description/title to reflect adding a current approver as well.
| [Zephyr](https://github.com/Zephyrcf) | Changfu Zhang | zinsist777@gmail.com | University of Science and Technology Beijing |
roles/Approvers.md:27
- This section says the emeritus approvers list is sorted alphabetically by name, but the newly added rows aren’t (e.g., Yadong Ding (D) appears after QinQi Zhai (Q) and Shang Zhao (S)). Please reorder the rows or update the sentence if sorting isn’t required.
Below is the list of emeritus (retired) approvers. Thank them for their contribution to the project. The list is sorted alphabetically by name.
| GitHub ID | Name | Email | Company or Organization |
| :-------------------------------------------: | :---------: | :-----------------------------: | :-----------------------------: |
| [adamqqqplay](https://github.com/adamqqqplay) | QinQi Zhai | adamqqq@163.com | Alibaba Group |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
link with dragonflyoss/nydus#1886