Fix IME keyobard state when search-only native input programatically hidden#9119
Open
LukasPaczos wants to merge 1 commit into
Open
Fix IME keyobard state when search-only native input programatically hidden#9119LukasPaczos wants to merge 1 commit into
LukasPaczos wants to merge 1 commit into
Conversation
Contributor
Author
|
I'm now noticing that the issue doesn't occur when toggle is enabled. It only occurs in search-only mode. I'll investigate further. |
LukasPaczos
marked this pull request as draft
July 8, 2026 09:49
LukasPaczos
force-pushed
the
fix/lpaczos/native-input-subs-cta-keyboard-visible
branch
from
July 8, 2026 10:20
761a242 to
82adfee
Compare
…ot only on back pressed
LukasPaczos
force-pushed
the
fix/lpaczos/native-input-subs-cta-keyboard-visible
branch
from
July 8, 2026 10:28
82adfee to
2e875a4
Compare
LukasPaczos
marked this pull request as ready for review
July 8, 2026 10:28
Contributor
Author
|
This is ready for review. |
Contributor
Author
|
bugbot run |
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 2e875a4. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1202552961248957/task/1216301005437164?focus=true
Tech Design URL (if applicable):
Description
Fixes regression from #8929 by extending a fix introduced in #8945 - it fixed the native input search-only state when a back button is used, but didn't apply the same fix for other programmatic sources that hide the native input widget.
Steps to test this PR
regression test: search path
regression test: chat path
regression test: backing out from focused address
regression test: backing out Duck.ai mode
Apply below patch:
test: search path with subscription
test: chat path with subscription
Note
Low Risk
Small, localized IME/focus ordering change in native input teardown with no auth, data, or security impact.
Overview
Fixes a regression where the soft keyboard could pop back up after the native input widget was dismissed programmatically in search-only mode, because the
EditTextstill held IME focus.clearInputFocus()now runs at the start ofhideNativeInput()for every dismissal path (onboarding CTAs, submit/navigation, feature toggles, etc.), not only when the widget’s back handler runs. That matches the earlier back-button fix and stops the window from re-requesting the keyboard after hide. In search-and-Duck.ai mode the field is usually already unfocused, so this is effectively a no-op there.Reviewed by Cursor Bugbot for commit 2e875a4. Bugbot is set up for automated code reviews on this repo. Configure here.