Skip to content

FE-856: Fix jsx leaked render + broken entity table filtering in hash-frontend#8858

Merged
alex-e-leon merged 3 commits into
mainfrom
FE-856-fix-jsx-leaked-rendering
Jun 11, 2026
Merged

FE-856: Fix jsx leaked render + broken entity table filtering in hash-frontend#8858
alex-e-leon merged 3 commits into
mainfrom
FE-856-fix-jsx-leaked-rendering

Conversation

@alex-e-leon

@alex-e-leon alex-e-leon commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

🌟 What is the purpose of this PR?

  • adds react-x/no-leaked-conditional-rendering to hash-frontend eslint. eslint-plugin-react-x is typeaware so is better then eslint-plugin-react. Also fixes any existing issues found
  • also fixes broken entity table filtering

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

@vercel

vercel Bot commented Jun 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview, Comment Jun 11, 2026 5:51pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
hashdotdesign-tokens Ignored Ignored Preview Jun 11, 2026 5:51pm
petrinaut Skipped Skipped Jun 11, 2026 5:51pm

@cursor

cursor Bot commented Jun 11, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Archived filtering changes affect entity tables, sidebar counts, and comment-notification deduplication queries; incorrect behavior could hide or show wrong entities until verified.

Overview
hash-frontend adds eslint-plugin-react-x and enables react-x/no-leaked-conditional-rendering, then fixes existing violations: optional UI blocks use condition ? … : null instead of &&, and hasMoreRowsAvailable is coerced with !! so numeric 0 cannot leak into the tree.

Entity query filters are corrected by dropping the extra any clause on the archived system property in build-filter.ts, use-entity-type-entities.tsx, and getCommentNotification in hash-api. Excluding archived rows now relies on notEqual on the top-level archived path only, which fixes broken entity table filtering when the old combined filter was applied.

hash-api comment-notification lookup is aligned with that simpler archived filter (mention notifications already used pageOrNotificationNotArchivedFilter elsewhere).

Reviewed by Cursor Bugbot for commit f9e5b5d. Bugbot is set up for automated code reviews on this repo. Configure here.

@alex-e-leon alex-e-leon enabled auto-merge June 11, 2026 17:01
@github-actions github-actions Bot added area/deps Relates to third-party dependencies (area) area/apps > hash* Affects HASH (a `hash-*` app) type/eng > frontend Owned by the @frontend team area/apps labels Jun 11, 2026
@vercel vercel Bot temporarily deployed to Preview – petrinaut June 11, 2026 17:04 Inactive
@alex-e-leon alex-e-leon changed the title FE-856: Fix jsx leaked rendering in hash-frontend FE-856: Fix jsx leaked render + broken entity table filtering in hash-frontend Jun 11, 2026
Comment thread apps/hash-frontend/src/pages/shared/entities-visualizer/data/build-filter.ts Outdated
@alex-e-leon alex-e-leon force-pushed the FE-856-fix-jsx-leaked-rendering branch from 7eff6c0 to 6a24559 Compare June 11, 2026 17:39
@vercel vercel Bot temporarily deployed to Preview – petrinaut June 11, 2026 17:39 Inactive
@github-actions github-actions Bot added area/apps > hash-api Affects the HASH API (app) type/eng > backend Owned by the @backend team labels Jun 11, 2026
@vercel vercel Bot temporarily deployed to Preview – petrinaut June 11, 2026 17:44 Inactive

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f9e5b5d. Configure here.

Comment thread apps/hash-api/src/graph/knowledge/system-types/notification.ts
Comment thread apps/hash-frontend/src/shared/use-entity-type-entities.tsx
@alex-e-leon alex-e-leon added this pull request to the merge queue Jun 11, 2026
Merged via the queue into main with commit 2d8863e Jun 11, 2026
51 checks passed
@alex-e-leon alex-e-leon deleted the FE-856-fix-jsx-leaked-rendering branch June 11, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-api Affects the HASH API (app) area/apps area/deps Relates to third-party dependencies (area) type/eng > backend Owned by the @backend team type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

2 participants