Adding searchBar integration for the page customConten#322
Open
miriwalid wants to merge 1 commit into
Open
Conversation
customContentIntegration variable is false by default, when turned to true it will fit inside the menu bar (customContent variable in fluidControls.Page)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a problem when including the searchBar inside the menuBar (Page/customContents)
I added a new variable customContentIntegration (false by default), when used and changed to true the searchBar will fit inside the menu bar (customContent variable in fluidControls.Page)
The following screenshots shows the layouting problems without the changes of this PR:
