Skip to content

Fix dual adjoint BC setter#1612

Merged
ebchin merged 16 commits into
developfrom
bugfix/ebchin/fix-dual-adjoint-bcs
Jun 12, 2026
Merged

Fix dual adjoint BC setter#1612
ebchin merged 16 commits into
developfrom
bugfix/ebchin/fix-dual-adjoint-bcs

Conversation

@ebchin

@ebchin ebchin commented Jun 2, 2026

Copy link
Copy Markdown
Member
  • Improves parsing of dual adjoint BC field names (first tries to match in derived class, then calls base class version)
  • Removes contact_forces as a dual field in favor of a dual field for each contact force (e.g. contact_force_0, contact_force_1, etc.)

@ebchin ebchin self-assigned this Jun 2, 2026
Comment thread src/smith/physics/solid_mechanics_contact.hpp Outdated
@ebchin ebchin changed the base branch from develop to bugfix/ebchin/fe-dual-move June 8, 2026 18:51
@ebchin ebchin changed the base branch from bugfix/ebchin/fe-dual-move to develop June 11, 2026 17:37
Comment thread src/smith/physics/solid_mechanics_contact.hpp
@chapman39

Copy link
Copy Markdown
Collaborator

@lc-hubcast approve

@lc-hubcast

lc-hubcast Bot commented Jun 11, 2026

Copy link
Copy Markdown

To approve the sync of this PR, please use the GitHub review comment feature to submit an approval. This ensures the approval is tied to a specific commit to avoid unintended syncing of malicious commits.

@chapman39 chapman39 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lc-hubcast approve

@chapman39

Copy link
Copy Markdown
Collaborator

i was testing to see if the hubcast approve command would force the ci to run as me and turns out it'll still run as eric i guess.

@ebchin

ebchin commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

@lc-hubcast approve

@lc-hubcast

lc-hubcast Bot commented Jun 12, 2026

Copy link
Copy Markdown

To approve the sync of this PR, please use the GitHub review comment feature to submit an approval. This ensures the approval is tied to a specific commit to avoid unintended syncing of malicious commits.

@ebchin ebchin left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lc-hubcast approve

@ebchin ebchin merged commit 0911fb9 into develop Jun 12, 2026
17 checks passed
@ebchin ebchin deleted the bugfix/ebchin/fix-dual-adjoint-bcs branch June 12, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants