fix(trace-viewer): add keyboard navigation to NetworkFilters component#41177
Open
triemerge wants to merge 1 commit into
Open
fix(trace-viewer): add keyboard navigation to NetworkFilters component#41177triemerge wants to merge 1 commit into
NetworkFilters component#41177triemerge wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The
NetworkFiltersresource type buttons in the trace viewer haverole="tablist"androle="tab"ARIA attributes but lack keyboard navigation, making them inaccessible to keyboard-only users.Fixes #41175
Changes
packages/trace-viewer/src/ui/networkFilters.tsxnow implements the ARIA Tabs keyboard interaction pattern:ArrowRightArrowLeftHomeEndThe "All" button was also missing
role="tab"andaria-selected, both are now set.All tabs use the roving
tabIndexpattern ; selected tabs havetabIndex={0}, unselected havetabIndex={-1}.Implementation Notes
role="tablist"container viaonKeyDown+refdocument.activeElementto find the focused tab indexe.preventDefault()on handled keys to prevent page scrollTests
Added a test in
tests/playwright-test/ui-mode-test-network-tab.spec.tscovering ArrowRight, ArrowLeft, Home, End, and wraparound navigation.