Skip to content

fix: declare axios (cli) and uuid (renderer) as dependencies#393

Merged
hkonsti merged 1 commit into
mainfrom
hkonsti/cli-renderer-phantom-deps
Jul 10, 2026
Merged

fix: declare axios (cli) and uuid (renderer) as dependencies#393
hkonsti merged 1 commit into
mainfrom
hkonsti/cli-renderer-phantom-deps

Conversation

@hkonsti

@hkonsti hkonsti commented Jul 10, 2026

Copy link
Copy Markdown
Member

Problem

On the canary getting-started flow, npm run start (revideo editor) crashes immediately:

Error: Cannot find module 'axios'
  ... @revideo/cli/dist/server/render.js:8

Cause

Two long-standing phantom dependencies that only ever resolved via hoisting inside this monorepo:

  • axios@revideo/cli's render server (src/server/render.ts) has imported it for webhook callbacks since feat: refactor cli and add reloading #82 (May 2024). It was never declared; it only resolved because lerna → nx pulls axios into the root node_modules. A consumer install has no axios, so loading the CLI (which eagerly imports the render server) throws.
  • uuid@revideo/renderer's server/validate-settings.ts imports it but never declared it; it resolves only because @revideo/ffmpeg hoists uuid. Latent breakage if that ever changes.

The canary's updated dep tree stopped providing axios transitively, which is why it surfaced now.

Fix

  • @revideo/cli: add "axios": "^1.16.0"
  • @revideo/renderer: add "uuid": "^14.0.1" (matches ffmpeg/cli)

Validation

Reproduced on a clean canary (0.10.5-alpha.1138) install. With axios present, revideo editor boots and serves HTTP 200. Ran a phantom-dependency audit across all node-executed packages; axios and uuid were the only genuine consumer-facing runtime misses (remaining flags are type-only imports, tsconfig path aliases, test-only devDeps, or pre-bundled editor/ui build deps).

Note

@revideo/cli also imports createServer from vite at runtime; it's always satisfied by the project's own vite, and declaring it here would introduce a third pinned vite amid the existing 4.5-vs-8 skew, so it's intentionally left alone.

Both were phantom dependencies that only resolved via hoisting inside
the monorepo (axios from lerna->nx, uuid from @revideo/ffmpeg). On a
clean consumer install they were missing:

- @revideo/cli imports axios for webhook callbacks in the render server;
  loading the CLI (e.g. 'revideo editor') threw 'Cannot find module axios'.
- @revideo/renderer imports uuid in validate-settings; it happened to
  resolve only because @revideo/ffmpeg hoists uuid.

Declare both explicitly.
@vercel

vercel Bot commented Jul 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
revideo-docs Skipped Skipped Jul 10, 2026 12:58am
revideo-docs-redirect Skipped Skipped Jul 10, 2026 12:58am

Request Review

@hkonsti hkonsti merged commit 957a812 into main Jul 10, 2026
9 checks passed
@hkonsti hkonsti deleted the hkonsti/cli-renderer-phantom-deps branch July 10, 2026 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant