fix: declare axios (cli) and uuid (renderer) as dependencies#393
Merged
Conversation
Both were phantom dependencies that only resolved via hoisting inside the monorepo (axios from lerna->nx, uuid from @revideo/ffmpeg). On a clean consumer install they were missing: - @revideo/cli imports axios for webhook callbacks in the render server; loading the CLI (e.g. 'revideo editor') threw 'Cannot find module axios'. - @revideo/renderer imports uuid in validate-settings; it happened to resolve only because @revideo/ffmpeg hoists uuid. Declare both explicitly.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the canary getting-started flow,
npm run start(revideo editor) crashes immediately:Cause
Two long-standing phantom dependencies that only ever resolved via hoisting inside this monorepo:
axios—@revideo/cli's render server (src/server/render.ts) has imported it for webhook callbacks since feat: refactor cli and add reloading #82 (May 2024). It was never declared; it only resolved becauselerna → nxpullsaxiosinto the rootnode_modules. A consumer install has noaxios, so loading the CLI (which eagerly imports the render server) throws.uuid—@revideo/renderer'sserver/validate-settings.tsimports it but never declared it; it resolves only because@revideo/ffmpeghoistsuuid. Latent breakage if that ever changes.The canary's updated dep tree stopped providing
axiostransitively, which is why it surfaced now.Fix
@revideo/cli: add"axios": "^1.16.0"@revideo/renderer: add"uuid": "^14.0.1"(matches ffmpeg/cli)Validation
Reproduced on a clean canary (
0.10.5-alpha.1138) install. Withaxiospresent,revideo editorboots and serves HTTP 200. Ran a phantom-dependency audit across all node-executed packages;axiosanduuidwere the only genuine consumer-facing runtime misses (remaining flags are type-only imports, tsconfig path aliases, test-only devDeps, or pre-bundled editor/ui build deps).Note
@revideo/clialso importscreateServerfromviteat runtime; it's always satisfied by the project's ownvite, and declaring it here would introduce a third pinnedviteamid the existing 4.5-vs-8 skew, so it's intentionally left alone.