Split manual Glama handoff from active queue#3100
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new "Manual handoff gates" section to the growth metrics markdown report, grouping open integrations that require manual actions (such as submitting to Glama) and sorting them by repository stars. Feedback focuses on preventing duplicate listings of these integrations in the "Manual review gates" section, and improving the robustness of the new test's string parsing logic to avoid potential index errors.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| manual_handoff_integrations = sorted( | ||
| ( | ||
| integration | ||
| for integration in metrics["integrations"] | ||
| if integration.get("state") == "open" | ||
| and (integration.get("next_action") or "inspect") in MANUAL_HANDOFF_ACTIONS | ||
| ), | ||
| key=lambda integration: int(integration.get("repo_stars") or 0), | ||
| reverse=True, | ||
| ) |
There was a problem hiding this comment.
The introduction of the ## Manual handoff gates section causes integrations like punkpeye/awesome-mcp-servers#7153 (which have both a manual handoff action and a known review gate reason) to be listed twice: once under ## Manual handoff gates and again under ## Manual review gates.
To avoid this redundancy and keep the report clean, we should filter out manual handoff integrations from the review_gate_integrations list. Since review_gate_integrations is defined on lines 680-682, you can update its definition to:
review_gate_integrations = [
integration for integration in metrics["integrations"]
if integration.get("known_review_gate_reason")
and (integration.get("next_action") or "inspect") not in MANUAL_HANDOFF_ACTIONS
]| active_queue = output.split("## Active operator queue", 1)[1].split("## Manual handoff gates", 1)[0] | ||
| manual_gates = output.split("## Manual handoff gates", 1)[1].split("## Manual review gates", 1)[0] |
There was a problem hiding this comment.
The current assertion logic is fragile because it assumes that the ## Manual review gates section will always be present in the output. If we filter out manual handoff integrations from the review gates section (to fix the duplication issue), the ## Manual review gates section will not be rendered in this test, causing an IndexError on the split.
We should make the section extraction more robust by checking for the presence of subsequent headers before splitting.
active_queue = output.split("## Active operator queue", 1)[1].split("## Manual handoff gates", 1)[0]
manual_gates = output.split("## Manual handoff gates", 1)[1]
for header in ["## Manual review gates", "## Failed or pending checks"]:
if header in manual_gates:
manual_gates = manual_gates.split(header, 1)[0]
break
Summary
Verification
Evidence checked: