Skip to content

Add Total Stock Value Report documentation for SSMM#97

Open
sonzsara wants to merge 1 commit into
mainfrom
ENG-263
Open

Add Total Stock Value Report documentation for SSMM#97
sonzsara wants to merge 1 commit into
mainfrom
ENG-263

Conversation

@sonzsara

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new documentation page for the SSMM “Total Stock Value Report” Metabase question, describing the business purpose, parameters, and the SQL used to compute net on-hand quantity and value per stock item.

Changes:

  • Added a new markdown doc page under Care/Accounting/ for the report, including purpose/parameters/SQL/notes.
  • Included logic for purchases, dispenses, and “mistake/correction” stock outflows via a hardcoded destination location list.
Comments suppressed due to low confidence (1)

Care/Accounting/total_stock_value_report_ssmm.md:108

  • There is an extra trailing Markdown code fence (```), which will break rendering of the page below this point. Please remove the stray closing fence at the end of the file.
*Last updated: 2026-05-22*





💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Care/Accounting/total_stock_value_report_ssmm.md
Comment thread Care/Accounting/total_stock_value_report_ssmm.md
Comment thread Care/Accounting/total_stock_value_report_ssmm.md
LEFT JOIN emr_product ep ON eii.product_id = ep.id
LEFT JOIN emr_productknowledge epk ON ep.product_knowledge_id = epk.id
WHERE edo.status IN ('completed', 'in_progress', 'draft')
AND emd.status IN ('completed', 'in_progress', 'preparation')

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check if the status check is correct

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yesss

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about on_hold?

LEFT JOIN emr_inventoryitem eii ON eii.id = emd.item_id
LEFT JOIN emr_product ep ON eii.product_id = ep.id
LEFT JOIN emr_productknowledge epk ON ep.product_knowledge_id = epk.id
WHERE edo.status IN ('completed', 'in_progress', 'draft')

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Dispense order status have any effect on stiock?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it does . When that condition is removed, additional dispense rows get included, which lowers the net stock value

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is understood but how does our backend calculate stock now? Is order status checked in inventory calculation?

Comment thread Care/Accounting/total_stock_value_report_ssmm.md

@yash-learner yash-learner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random question

Does this exclude or include return supply delivery from patient ?

LEFT JOIN emr_inventoryitem eii ON eii.id = emd.item_id
LEFT JOIN emr_product ep ON eii.product_id = ep.id
LEFT JOIN emr_productknowledge epk ON ep.product_knowledge_id = epk.id
WHERE edo.status IN ('completed', 'in_progress', 'draft')

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is understood but how does our backend calculate stock now? Is order status checked in inventory calculation?

LEFT JOIN emr_product ep ON eii.product_id = ep.id
LEFT JOIN emr_productknowledge epk ON ep.product_knowledge_id = epk.id
WHERE edo.status IN ('completed', 'in_progress', 'draft')
AND emd.status IN ('completed', 'in_progress', 'preparation')

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about on_hold?

AND edo.origin_id IS NULL
AND esd.deleted = FALSE
AND edo.deleted = FALSE
AND edo.status = 'completed'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delivery order status check here also

AND edo.destination_id IN (264,270,280,274,273,275,276,266,279,36,265,278,297,238,298,27,481,17,32,277)
AND esd.deleted = FALSE
AND edo.deleted = FALSE
AND edo.status IN ('completed', 'in_progress')

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants