fix: add missing org scope support in instructor dashboard

[BryanttV]

Description

This PR extends the legacy role compatibility layer to support AuthZ role assignments with org-wide scopes (OrgCourseOverviewGlobData, e.g., course-v1:OpenedX+*). Previously, AuthZ roles were only mapped when the scope was a specific course (CourseOverviewData). Users with organization-level permissions did not receive access in code paths that rely on the legacy role system.

Additionally, it fixes a bug in the legacy role system where roles assigned at the org level were also not working correctly, only course-level roles.

Additional Information

• has_access(..., "staff", course_key) already considers OrgStaffRole and OrgInstructorRole via administrative_accesses_to_course_for_user, which is why it is the correct check for APIs such as cohorts.
• _get_legacy_accessible_courses_list was modified since UserBasedRole.courses_with_role() was not reading only legacy data, but was merging AuthZ permissions. The direct query to CourseAccessRole ensures that only legacy assignments are retrieved.

Supporting information

• [Test failure] TC-00615: Users with admin/staff roles at org level cannot access the Instructor Dashboard using RBAC wg-build-test-release#591

Testing instructions

Note

Perform the test using both the legacy system and the new RBAC system.

1. Assign the Admin role to a user at the organization level:
   • If you are using the legacy system, you can only do this from the Django Admin at {lms_domain}/admin/student/courseaccessrole.
   • If you are using the RBAC system, you can do this from the Admin Console in Studio.
2. Assign the Staff role to a user at the organization level. Follow the same instructions as the previous step.
3. Go to the Instructor Dashboard of any of the courses that belong to the organization. You should be able to access it without any issues.
4. Go to Cohorts, you should be able to enable/disable the feature or create a Cohort without any issues.
5. You can also check using Dev Tools > Network to verify that all requests are working and not returning a 403 error.

Screenshots

Before

After

Deadline

Verawood

[openedx-webhooks]

Thanks for the pull request, @BryanttV!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.