fix: remove the asciidoctor dependency#5119
Merged
Merged
Conversation
DeepDiver1975
approved these changes
Jul 2, 2026
DeepDiver1975
left a comment
DeepDiver1975
left a comment
Member
There was a problem hiding this comment.
Verified: removes orphaned asciidoctor npm dep (+lockfile prune); no remaining consumer (extensions use Antora-bundled Asciidoctor via the Opal/Asciidoctor globals, not the standalone package; asciidoctor-kroki retained). Full Antora build CI green.
🤖 Generated with Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the asciidoctor dependency.
This dep is a legacy dating back long time ago when a special mechanism was used to create PDFs.
This mechanism has been removed years ago but we "forgot" to remove the dependency.
Antora can now create PDFs in a new and very professional way using Antora Assembler where all dependencies are part of the assembler setup.
Note that the UI is independent and needs the assembler dependency with the version fixed to 3.x which is for building the test page when developing the UI.
The removal has been tested locally running a full docs build and no issues occurred.