Skip to content

chore: rename module to @prometheus/client_js#751

Open
cjihrig wants to merge 1 commit into
prometheus:mainfrom
cjihrig:project-rename
Open

chore: rename module to @prometheus/client_js#751
cjihrig wants to merge 1 commit into
prometheus:mainfrom
cjihrig:project-rename

Conversation

@cjihrig

@cjihrig cjihrig commented Jun 25, 2026

Copy link
Copy Markdown

This commit updates the project name from prom-client to @prometheus/client_js to reflect the recent move.

This is my first time contributing to this project under any package name, so please let me know if anything here is incorrect.

This commit updates the project name from prom-client to
@prometheus/client_js to reflect the recent move.
@slagiewka

Copy link
Copy Markdown

I know that @krajorama mentioned client_js as the desired state in #750 (comment). But this might've been intended to point to the repository name, not package name.

Reality check:
Python: pip install prometheus-client
Ruby: gem install prometheus-client
Rust: cargo add prometheus-client

Go is of course an outlier since it imports directly from domain's namespace. And in Go packages with _ in name are more commonplace.

prometheus-client is taken on npm. @prometheus/client would be more aligned with the npm ecosystem.

@krajorama krajorama requested a review from jdmarshall June 25, 2026 10:50
@krajorama

krajorama commented Jun 25, 2026

Copy link
Copy Markdown
Member

I don't have a strong opinion, I feel that @prometheus-io/client_js would be nice to reflect the name of the repo it comes from, but I'm ok with @prometheus-io/client as well. (Note : currently Prometheus publishes packages under prometheus-io).

@jdmarshall any preference?

UPDATE: as far as I see I can freely add @prometheus organization, so we can do @prometheus prefix as well.

@cjihrig

cjihrig commented Jun 25, 2026

Copy link
Copy Markdown
Author

Personally, I think @prometheus/client would be the nicest and clearest, since that is what people will be typing when they install. However, if @prometheus-io is already being used, then I think @prometheus-io/client would be the best option to avoid confusion and managing multiple package scopes. The _js probably isn't needed since the package is coming from npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants