Fixes to factory to handle ignore_external.#293
Merged
Conversation
Contributor
Author
|
The issue is now that |
Contributor
|
Yes that's normal that |
Contributor
Author
|
So you want this error if the user does I thought maybe it would be better to return None? |
Contributor
|
Yes for me it is fine. |
Contributor
Author
|
Maybe it is just that: Should be: and the error will be gone. |
Contributor
Author
|
Yes, that would fix it. Unless there is a reason why those two attributes doesn't have self before? |
JeanLucPons
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fix issue #292.
I have added so the factory returns None instead of building an object if ignore_external = True and the module isn't found.
I had to also add a fix in the linear magnet module to handle the case when the powerconverter becomes None.