API keys support on the backend#379
Conversation
…ect /api/watched endpoint using the APIKeyMiddleware
There was a problem hiding this comment.
Hey @titanventura, thanks for making a PR (and sorry for taking so long getting to it)!
I had a quick look and noticed some changes we could make, let me know if you have any thoughts on the feedback.
I noticed the APIKeyMiddlewareWrapper, did adding the header check to the AuthRequired middleware not work out? I think that way would be preferable, just need to move the x-api-key header check into AuthRequired and if we find it, we can process it as an API key instead (in APIKeyMiddlewareWrapper, if you'd like, but probably renamed).
I know this is a draft, so you may have been getting to this, but the route handlers seem to have all the logic in them. We could separate most of it out to 'service' functions.
Thanks again for taking the time!
| ID uint `gorm:"primarykey" json:"id"` | ||
| CreatedAt time.Time `json:"createdAt"` | ||
| Value string `gorm:"not null" json:"value"` | ||
| UserID uint `gorm:"not null" json:"-"` |
There was a problem hiding this comment.
We may want to make this a foreign key that maps to a User to ensure data integrity.
| "gorm.io/gorm" | ||
| ) | ||
|
|
||
| type ApiKey struct { |
There was a problem hiding this comment.
An UpdatedAt field might be worth adding in here too.
…s and change middleware structure
|
@IRHM , please go through the updated PR. Thanks ! |
|
Hi @titanventura, I'm happy to get this merged. Thanks for the good work! There are a few minor things, but It's probably best I do them after deciding how the UI will work so it isn't wasted effort incase it needs changing. Thanks! |
|
Hi. How about this? |
3 participants
Fixes #360 partially
Changes made
/api/watchedendpoint