Skip to content

Update default version of require.js #853

Open
kasium wants to merge 1 commit into
spatialaudio:masterfrom
kasium:issue-851
Open

Update default version of require.js #853
kasium wants to merge 1 commit into
spatialaudio:masterfrom
kasium:issue-851

Conversation

@kasium

@kasium kasium commented Nov 11, 2025

Copy link
Copy Markdown

Closes #851

@mgeier

mgeier commented Nov 11, 2025

Copy link
Copy Markdown
Member

Thanks for this PR!

Sadly, it doesn't seem to work, see the rendered documentation of "widgets": https://nbsphinx--853.org.readthedocs.build/en/853/code-cells.html#Interactive-Widgets-(HTML-only)

There's an error in the JavaScript console that's probably related:

Uncaught ReferenceError: define is not defined
    <anonymous> https://cdn.jsdelivr.net/npm/@jupyter-widgets/html-manager@^1.0.1/dist/embed-amd.js:2

@kasium

kasium commented Nov 11, 2025

Copy link
Copy Markdown
Author

Good point, I'm not an expert in this area. For the issue raised in my project updating require.js was the solution. I'm also confused that a patch level increase can cause this issue. Let me check the changelog

@kasium

kasium commented Nov 11, 2025

Copy link
Copy Markdown
Author

Mhm, there is no changelog and the changes don't look related: requirejs/requirejs@2.3.4...2.3.7

However when lookin into other PRs like #849 I think your CI is broken :-)

@mgeier

mgeier commented Nov 11, 2025

Copy link
Copy Markdown
Member

However when lookin into other PRs like #849 I think your CI is broken :-)

Yes, see #844, help is always welcome.

But this should be independent, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update default version of require.js

2 participants