Add native Windows CI build and remove unused allocations in CGNS surface reader#2739
Open
mohanakatari119-bit wants to merge 2 commits intosu2code:developfrom
Open
Add native Windows CI build and remove unused allocations in CGNS surface reader#2739mohanakatari119-bit wants to merge 2 commits intosu2code:developfrom
mohanakatari119-bit wants to merge 2 commits intosu2code:developfrom
Conversation
Contributor
|
Thank you for identifying the source of this issue. I think from a maintainer standpoint it would be useful if we could resolve the issue from the Linux to Windows perspective, is this possible from your investigations? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adds a native Windows GitHub Actions workflow that builds SU2 on a
windows-latestrunner using MSYS2/MinGW64, replacing the cross-compiled Windows binaries that were previously built on Linux. Also removes four unused vector allocations (connElemCGNS,elemTypes,nPoinPerElem,elemGlobalID) inCCGNSMeshReaderFVM::ReadCGNSSurfaceSectionthat were allocated based on a stalenElems[val_section]value (always zero at that point in the call sequence) and were never read, left over from a prior refactoring.Related Work
Resolves #2737 (SU2_DEF Windows binaries segfaulting when converting CGNS meshes). The root cause is that the existing release workflow cross-compiles Windows binaries on Linux, which prevents
H5detectfrom running natively during the HDF5 build. This means type-detection falls back to a genericH5T_init.crossfile that may not match the actual Windows runtime, causing memory corruption and segfaults in the CGNS reader. Building natively on Windows eliminates this mismatch. Related to issue #1468.PR Checklist
pre-commit run --allto format old commits.