Replace onebox.go [wip]#10319
Draft
stephanos wants to merge 1 commit into
Draft
Conversation
stephanos
force-pushed
the
stephanos/rm-onebox
branch
14 times, most recently
from
6e911b9 to
d2bd371
Compare
stephanos
commented
May 18, 2026
| @@ -69,8 +59,6 @@ import ( | |||
|
|
|||
| type ( | |||
| TemporalImpl struct { | |||
Contributor
Author
There was a problem hiding this comment.
There are many more refactorings that can be done here, but keeping it to an absolute minimum here.
stephanos
force-pushed
the
stephanos/rm-onebox
branch
3 times, most recently
from
e935010 to
4f3cee0
Compare
stephanos
force-pushed
the
stephanos/rm-onebox
branch
11 times, most recently
from
832deab to
6ea1fbd
Compare
stephanos
force-pushed
the
stephanos/rm-onebox
branch
from
6ea1fbd to
d59e4f0
Compare
stephanos
force-pushed
the
stephanos/rm-onebox
branch
from
d59e4f0 to
6c02558
Compare
stephanos
force-pushed
the
stephanos/dlq-testhooks
branch
2 times, most recently
from
f161a36 to
9a2d942
Compare
stephanos
force-pushed
the
stephanos/rm-onebox
branch
6 times, most recently
from
98a8892 to
6357fc6
Compare
stephanos
commented
Jun 5, 2026
| // WithFxOptions appends fx options to a specific service's fx graph. This | ||
| // implies a dedicated cluster because custom fx options cannot be shared | ||
| // across tests. | ||
| func WithFxOptions(serviceName primitives.ServiceName, opts ...fx.Option) TestOption { |
stephanos
commented
Jun 5, 2026
| // RPCAddress and HTTPAddress will be filled in | ||
| }, | ||
| } | ||
| clusterConfigs[clusterIndex].ServiceFxOptions = params.ServiceOptions |
stephanos
force-pushed
the
stephanos/rm-onebox
branch
2 times, most recently
from
82e8481 to
4e8718a
Compare
stephanos
force-pushed
the
stephanos/rm-onebox
branch
from
4e8718a to
0f2897e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This is the root onebox replacement branch. Keep it draft until the remaining customization points below are split out or resolved.
Goal
The only public
temporalpackage addition should beWithTestHooks. All other onebox customizations must either move to existing config/dynamic config, become a focused testhook, or find a test-side workaround.Remaining blockers
HistoryServiceRefsCreatedwith a focused CHASM dependency hook: Add CHASM test support hook #10582.ServiceGrpcInterceptorsandServiceClientDialOptionsare broad global hooks today; either narrow them to recorder-specific testhooks or find another workaround. No PR yet.PersistenceExecutionManagerWrapperwith an opt-inTaskQueueRecorderbacked by a focused history task write hook: Add history task write test hook #10583.ChasmRegistryInitializer. It is currently a broadanyhook for registering the test CHASM library; make it typed/focused or replace it with a test-side registration path. No PR yet.temporalpackage diff. KeepWithTestHooksand required internal plumbing only; remove or split any other behavior change, including the static-host validation relaxation if it is still needed. No PR yet.