fix flaky tampered TK_HASHCHECK ticket negative test#526
Merged
dgarske merged 1 commit intoJun 12, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes an intermittent (flaky) negative test in the tpm2-tools compatibility test script by making ticket tampering deterministic. It updates the TK_HASHCHECK tamper step so that the ticket is reliably corrupted regardless of the original byte value.
Changes:
- Replace single-byte tampering at a fixed offset with overwriting the trailing half of the ticket with
0xAA. - Add an explanatory comment documenting why the previous approach could be a no-op (~1/256 of runs) and thus flaky.
dgarske
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.