Make compressors more usable from Java context#257
Open
vigorouscoding wants to merge 2 commits intoyui:masterfrom
vigorouscoding:master
Open
Make compressors more usable from Java context#257vigorouscoding wants to merge 2 commits intoyui:masterfrom vigorouscoding:master
vigorouscoding wants to merge 2 commits intoyui:masterfrom
vigorouscoding:master
Conversation
added 2 commits
August 22, 2016 15:58
- introduce a constructor which takes a String argument so we do not need a file - move actual CSS compression to method `getCompressedCss()` so we can obtain the minified CSS without needing to write it to a file
- introduced a new constructr which takes a String argument so we do not need a file - move actuall JS compression to `getCompressedCode()` method so we can obtain the minified JS without needing to write to a file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes YUICompressor more flexible for usage in other software products.
It enables the user to pass JS/CSS Strings instead of files to the compressors - it also enables the user to grab the minified code without having to write it to a file.
It does not impact the functionality of the compressors at all, it merely adds layer to the compressors which can act as a point of extension or can be used as is to simply retrieve the compressed JS/CSS without reading/writing it from/to a file.
All tests pass since no extra functionality is introduced. I tried my best to adopt your coding style and indentation rules and hope you think this code benefits YUICompressor :)