fix: restore edit-selected-file keyboard shortcut (e key)#402
Conversation
Re-add support for the 'e' key to open the selected file in $EDITOR. Update help dialog to document the restored shortcut.
Greptile SummaryThis PR restores the
Confidence Score: 5/5Safe to merge — the change is a targeted restoration of a previously removed keyboard binding with no side effects on other shortcuts. The two-line hook change follows the identical pattern used by every other action shortcut in the file, and triggerEditSelectedFile was already declared in the interface, confirming the binding was intentionally removed rather than never implemented. The help dialog entry keeps documentation in sync. No existing shortcuts are affected. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
KE[KeyEvent received] --> MT{handleMenuToggleShortcut?}
MT -->|yes| END[return]
MT -->|no| PM{pagerMode?}
PM -->|yes| PS[handlePagerShortcut]
PM -->|no| HS{handleHelpShortcut?}
HS -->|yes| END
HS -->|no| MS{handleMenuShortcut?}
MS -->|yes| END
MS -->|no| FI{handleFocusedInputShortcut?}
FI -->|yes| END
FI -->|no| AS[handleAppShortcut]
AS --> EK{"key === 'e'?"}
EK -->|yes| CM["runAndCloseMenu(triggerEditSelectedFile)"]
EK -->|no| OTHER[other shortcuts...]
CM --> END
Reviews (1): Last reviewed commit: "fix: restore edit-selected-file keyboard..." | Re-trigger Greptile |
Display 'e' hint in the app menu for 'Open file in editor' action. Update help dialog test to reflect the restored shortcut.
|
Oops 😅 |
Increase test terminal height from 38 to 39 rows. The HelpDialog content (37 rows) plus modal chrome (6 rows) requires exactly 39 rows to display without scrolling. At height=38, the modal capped at 36 rows, triggering scrollbox and hiding the bottom control rows like 'r / q' from the captured frame, causing the test to fail. This minimal adjustment ensures all documented control rows render in the test's viewport without activation of the scrollbox.
hehe, it happens. i updated the failing tests. ^^ |
|
Me would like to have it back :) |
|
the windows compat test timedout, hmm not sure if its related this PR's change. can we probably retry the test? |
Re-add support for the 'e' key to open the selected file in $EDITOR. Update help dialog to document the restored shortcut.
prolly from a silent merge conflict of #310 and #303