Fix FXAA pass ignoring RenderResolutionDivisor#311
Conversation
applyFXAA forced the full world-view viewport before blitting into the FXAA destination, but that destination is an FBO whose viewport bindTarget already set. Under RenderResolutionDivisor the reduced-size target then received output only in its lower-left fraction. Drop the override and let the bound target's viewport stand. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR adjusts the FXAA multisample rendering path in ChangesFXAA Multisample Viewport Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
With FXAA antialiasing enabled and
RenderResolutionDivisor>=2, the FXAA pass would only write to the lower-left fraction of the reduced-resolution target.Should help those that may want to keep render HiDPI on but render at a lower resolution.