fix(certificateParentMerger): append child externalContents to parent ones instead of overriding (ARI-3292)#490
Open
stefdelec wants to merge 1 commit into
Open
fix(certificateParentMerger): append child externalContents to parent ones instead of overriding (ARI-3292)#490stefdelec wants to merge 1 commit into
stefdelec wants to merge 1 commit into
Conversation
… ones instead of overriding (ARI-3292) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quoi
certificateParentMergerfusionnait parent/enfant avecmergeWithsans customizer : les tableaux étaient fusionnés index par index, donc le 1erexternalContentsde l'enfant écrasait la notice du parent. Désormais lesexternalContentssont concaténés (parent d'abord, dédoublonnage des entrées identiques).Pendant côté SDK legacy du fix backend ArianeeBrandDataHub#3846 (mêmes corrections dans wallet-api#133 et arianee-sdk#421).
Comment
mergeWithreçoit désormais un customizer (lodash déjà utilisé) :externalContentsconcaténés (parent d'abord, dédoublonnageuniqWith(isEqual)) ;i18nmergé par langue (langues parent seules conservées, langues enfant seules ajoutées), avec concaténation desexternalContentspar langue ;Tests
it should merge in order parents) reste vert.Ticket : ARI-3292
🤖 Generated with Claude Code