Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for the new tokens endpoints to the ArkEcosystem PHP client, exposing a tokens() accessor on ArkClient and a dedicated Tokens API class, with accompanying request/URL-shape tests.
Changes:
- Introduce
ArkEcosystem\Client\API\Tokenswith methods for listing tokens, fetching a token, holders, transfers, and whitelist. - Add
ArkClient::tokens()accessor to instantiate the new API. - Add
TokensTestcoverage for the new endpoints’ request method + URL paths.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/ArkClient.php |
Exposes the new Tokens API via tokens() on the client. |
src/API/Tokens.php |
Implements request methods for tokens-related endpoints (GET + POST variant). |
tests/API/TokensTest.php |
Verifies the HTTP method + URL path for tokens endpoints. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://app.clickup.com/t/86e00w3wy
I didn't add any special handling for minBalance as it's just an additional query/parameter as far as I understand it 🤔
Checklist