Add c2sp.org/chunked-encryption (Cobblestone) test vectors#265
Add c2sp.org/chunked-encryption (Cobblestone) test vectors#265FiloSottile wants to merge 1 commit into
Conversation
|
Perfect, thanks! Our current PR uses the ones from your impl. |
|
These are ported from those, and the Go implementation (now renamed to filippo.io/cobblestone) now uses these. |
cpu
left a comment
cpu
left a comment
There was a problem hiding this comment.
Here's some initial feedback mainly focused on the new schema.
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ |
There was a problem hiding this comment.
I think source should also be a required field.
| }, | ||
| "sha": { | ||
| "type": "string", | ||
| "format": "MdName", |
There was a problem hiding this comment.
There's no validator registered for MdName in vectorlint so this is fairly decorative.
I think unless you plan to convert other schemas to use a defined+linted MdName format maybe this should just be an enum with some variants listed? Or should it be fixed to "SHA-512" since there are no chunked vectors using a different digest at this point.
| }, | ||
| "properties": { | ||
| "algorithm": { | ||
| "type": "string", |
There was a problem hiding this comment.
Can this be an enum with fixed values, something like: "enum": ["Cobblestone-128", "Cobblestone-256"]
| "description": "The derived base nonce, for testing raw mode directly (absent for invalid vectors that exercise key derivation or the commitment check)" | ||
| }, | ||
| "msgLength": { | ||
| "type": "integer", |
3 participants
/cc @alex @reaperhulk