feat: use css custom properties for theme color customization#550
Open
lekhmanrus wants to merge 1 commit intoCodeByZach:masterfrom
Open
feat: use css custom properties for theme color customization#550lekhmanrus wants to merge 1 commit intoCodeByZach:masterfrom
lekhmanrus wants to merge 1 commit intoCodeByZach:masterfrom
Conversation
Replace hardcoded color values in all compiled theme files with
CSS custom properties using `var(--pace-color, <original-color>)`.
This enables color customization via CSS:
```css
:root {
--pace-color: #ff6600;
}
```
Benefits:
- No breaking changes - default colors remain identical via fallback
- Works when included as static CSS in frameworks
- Eliminates the need to copy theme files locally for color changes
- Templates (`*.tmpl.css`) are unchanged for JS runtime customization
Signed-off-by: Ruslan Lekhman <lekhman112@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hardcoded color values in all compiled theme files with CSS custom properties using
var(--pace-color, <original-color>). This enables color customization via CSS:Benefits:
*.tmpl.css) are unchanged for JS runtime customization