Define alternative fonts to "Noto Sans" to support old browsers#171
Open
leocaseiro wants to merge 2 commits intoCoderLine:developfrom
Open
Define alternative fonts to "Noto Sans" to support old browsers#171leocaseiro wants to merge 2 commits intoCoderLine:developfrom
leocaseiro wants to merge 2 commits intoCoderLine:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @Danielku15,
This PR adds support for any device that doesn't have
Noto Sans, or had issues loading it somehow.For context, here is the reason I raised that PR.
I was having issues loading the alphatab notation on an old laptop, even though the audio was playing fine.
It's an old MacBook Air (maybe 2012) with High Sierra 10.13 32-bit (x86_64), which has an old Chrome 116.0.5845.187 x84_64. Probably the latest they had supported for x86.
Anyway, I decided to debug that, and it was an easy fix.
The logs had the following error:
As a workaround, I installed Noto Sans, and I got the same error for Noto Serif, and weird enough, I might not have installed the correct one, but I got the same error now for
Noto Serif.So instead, I decided to try fixing by adding alternative fonts as a fallback, and now it's working fine 🎉
It might look slightly different on some of the fonts, but it's still very good usage.
See an example here: