Mute tracing for agent http calls#10690
Mute tracing for agent http calls#10690gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 10 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~7fc7401f51, baseline=1.60.0-SNAPSHOT~1c44c6f9a7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.074 s) : 0, 1074455
Total [baseline] (8.769 s) : 0, 8769100
Agent [candidate] (1.074 s) : 0, 1074437
Total [candidate] (8.785 s) : 0, 8785194
section iast
Agent [baseline] (1.232 s) : 0, 1231619
Total [baseline] (9.387 s) : 0, 9386661
Agent [candidate] (1.243 s) : 0, 1243422
Total [candidate] (9.397 s) : 0, 9397117
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~7fc7401f51, baseline=1.60.0-SNAPSHOT~1c44c6f9a7
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (632.94 ms) : 0, 632940
BytebuddyAgent [candidate] (633.505 ms) : 0, 633505
AgentMeter [baseline] (29.577 ms) : 0, 29577
AgentMeter [candidate] (29.338 ms) : 0, 29338
GlobalTracer [baseline] (260.399 ms) : 0, 260399
GlobalTracer [candidate] (259.909 ms) : 0, 259909
AppSec [baseline] (33.595 ms) : 0, 33595
AppSec [candidate] (33.249 ms) : 0, 33249
Debugger [baseline] (65.322 ms) : 0, 65322
Debugger [candidate] (60.266 ms) : 0, 60266
Remote Config [baseline] (620.777 µs) : 0, 621
Remote Config [candidate] (636.28 µs) : 0, 636
Telemetry [baseline] (10.645 ms) : 0, 10645
Telemetry [candidate] (14.592 ms) : 0, 14592
Flare Poller [baseline] (3.785 ms) : 0, 3785
Flare Poller [candidate] (5.411 ms) : 0, 5411
section iast
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.213 ms) : 0, 1213
BytebuddyAgent [baseline] (796.116 ms) : 0, 796116
BytebuddyAgent [candidate] (805.095 ms) : 0, 805095
AgentMeter [baseline] (11.31 ms) : 0, 11310
AgentMeter [candidate] (11.57 ms) : 0, 11570
GlobalTracer [baseline] (247.599 ms) : 0, 247599
GlobalTracer [candidate] (248.857 ms) : 0, 248857
IAST [baseline] (26.976 ms) : 0, 26976
IAST [candidate] (27.349 ms) : 0, 27349
AppSec [baseline] (32.444 ms) : 0, 32444
AppSec [candidate] (31.481 ms) : 0, 31481
Debugger [baseline] (67.23 ms) : 0, 67230
Debugger [candidate] (68.853 ms) : 0, 68853
Remote Config [baseline] (546.057 µs) : 0, 546
Remote Config [candidate] (614.786 µs) : 0, 615
Telemetry [baseline] (8.606 ms) : 0, 8606
Telemetry [candidate] (8.654 ms) : 0, 8654
Flare Poller [baseline] (3.478 ms) : 0, 3478
Flare Poller [candidate] (3.461 ms) : 0, 3461
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~7fc7401f51, baseline=1.60.0-SNAPSHOT~1c44c6f9a7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064868
Total [baseline] (10.906 s) : 0, 10906149
Agent [candidate] (1.073 s) : 0, 1072953
Total [candidate] (10.964 s) : 0, 10963696
section appsec
Agent [baseline] (1.25 s) : 0, 1249866
Total [baseline] (11.02 s) : 0, 11020219
Agent [candidate] (1.244 s) : 0, 1244445
Total [candidate] (11.064 s) : 0, 11063515
section iast
Agent [baseline] (1.237 s) : 0, 1236882
Total [baseline] (11.268 s) : 0, 11267912
Agent [candidate] (1.236 s) : 0, 1236247
Total [candidate] (11.173 s) : 0, 11173497
section profiling
Agent [baseline] (1.201 s) : 0, 1201034
Total [baseline] (10.964 s) : 0, 10963864
Agent [candidate] (1.198 s) : 0, 1198035
Total [candidate] (10.986 s) : 0, 10985620
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~7fc7401f51, baseline=1.60.0-SNAPSHOT~1c44c6f9a7
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (627.117 ms) : 0, 627117
BytebuddyAgent [candidate] (632.532 ms) : 0, 632532
AgentMeter [baseline] (29.204 ms) : 0, 29204
AgentMeter [candidate] (29.281 ms) : 0, 29281
GlobalTracer [baseline] (257.137 ms) : 0, 257137
GlobalTracer [candidate] (259.663 ms) : 0, 259663
AppSec [baseline] (32.95 ms) : 0, 32950
AppSec [candidate] (33.285 ms) : 0, 33285
Debugger [baseline] (67.682 ms) : 0, 67682
Debugger [candidate] (60.987 ms) : 0, 60987
Remote Config [baseline] (614.267 µs) : 0, 614
Remote Config [candidate] (644.671 µs) : 0, 645
Telemetry [baseline] (9.052 ms) : 0, 9052
Telemetry [candidate] (13.748 ms) : 0, 13748
Flare Poller [baseline] (3.774 ms) : 0, 3774
Flare Poller [candidate] (5.358 ms) : 0, 5358
section appsec
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (663.653 ms) : 0, 663653
BytebuddyAgent [candidate] (659.508 ms) : 0, 659508
AgentMeter [baseline] (12.128 ms) : 0, 12128
AgentMeter [candidate] (12.102 ms) : 0, 12102
GlobalTracer [baseline] (260.574 ms) : 0, 260574
GlobalTracer [candidate] (260.525 ms) : 0, 260525
IAST [baseline] (25.673 ms) : 0, 25673
IAST [candidate] (25.696 ms) : 0, 25696
AppSec [baseline] (168.979 ms) : 0, 168979
AppSec [candidate] (168.41 ms) : 0, 168410
Debugger [baseline] (67.591 ms) : 0, 67591
Debugger [candidate] (67.017 ms) : 0, 67017
Remote Config [baseline] (684.319 µs) : 0, 684
Remote Config [candidate] (681.287 µs) : 0, 681
Telemetry [baseline] (9.453 ms) : 0, 9453
Telemetry [candidate] (9.492 ms) : 0, 9492
Flare Poller [baseline] (3.598 ms) : 0, 3598
Flare Poller [candidate] (3.704 ms) : 0, 3704
section iast
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (798.843 ms) : 0, 798843
BytebuddyAgent [candidate] (798.413 ms) : 0, 798413
AgentMeter [baseline] (11.402 ms) : 0, 11402
AgentMeter [candidate] (11.351 ms) : 0, 11351
GlobalTracer [baseline] (248.479 ms) : 0, 248479
GlobalTracer [candidate] (247.842 ms) : 0, 247842
IAST [baseline] (27.23 ms) : 0, 27230
IAST [candidate] (27.433 ms) : 0, 27433
AppSec [baseline] (36.152 ms) : 0, 36152
AppSec [candidate] (35.005 ms) : 0, 35005
Debugger [baseline] (64.763 ms) : 0, 64763
Debugger [candidate] (66.246 ms) : 0, 66246
Remote Config [baseline] (534.311 µs) : 0, 534
Remote Config [candidate] (555.334 µs) : 0, 555
Telemetry [baseline] (8.646 ms) : 0, 8646
Telemetry [candidate] (8.636 ms) : 0, 8636
Flare Poller [baseline] (3.458 ms) : 0, 3458
Flare Poller [candidate] (3.47 ms) : 0, 3470
section profiling
crashtracking [baseline] (1.177 ms) : 0, 1177
crashtracking [candidate] (1.174 ms) : 0, 1174
BytebuddyAgent [baseline] (688.487 ms) : 0, 688487
BytebuddyAgent [candidate] (687.574 ms) : 0, 687574
AgentMeter [baseline] (8.639 ms) : 0, 8639
AgentMeter [candidate] (8.614 ms) : 0, 8614
GlobalTracer [baseline] (217.613 ms) : 0, 217613
GlobalTracer [candidate] (216.749 ms) : 0, 216749
AppSec [baseline] (33.012 ms) : 0, 33012
AppSec [candidate] (32.745 ms) : 0, 32745
Debugger [baseline] (67.763 ms) : 0, 67763
Debugger [candidate] (67.538 ms) : 0, 67538
Remote Config [baseline] (641.371 µs) : 0, 641
Remote Config [candidate] (631.352 µs) : 0, 631
Telemetry [baseline] (8.957 ms) : 0, 8957
Telemetry [candidate] (8.875 ms) : 0, 8875
Flare Poller [baseline] (3.816 ms) : 0, 3816
Flare Poller [candidate] (3.766 ms) : 0, 3766
ProfilingAgent [baseline] (99.611 ms) : 0, 99611
ProfilingAgent [candidate] (99.221 ms) : 0, 99221
Profiling [baseline] (100.19 ms) : 0, 100190
Profiling [candidate] (99.788 ms) : 0, 99788
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 15 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~7fc7401f51, baseline=1.60.0-SNAPSHOT~1c44c6f9a7
dateFormat X
axisFormat %s
section baseline
no_agent (18.049 ms) : 17862, 18236
. : milestone, 18049,
appsec (18.819 ms) : 18627, 19010
. : milestone, 18819,
code_origins (17.371 ms) : 17200, 17543
. : milestone, 17371,
iast (17.929 ms) : 17747, 18111
. : milestone, 17929,
profiling (18.613 ms) : 18430, 18796
. : milestone, 18613,
tracing (18.756 ms) : 18564, 18949
. : milestone, 18756,
section candidate
no_agent (19.535 ms) : 19328, 19741
. : milestone, 19535,
appsec (18.602 ms) : 18417, 18786
. : milestone, 18602,
code_origins (17.38 ms) : 17207, 17552
. : milestone, 17380,
iast (18.797 ms) : 18603, 18991
. : milestone, 18797,
profiling (19.167 ms) : 18979, 19354
. : milestone, 19167,
tracing (17.667 ms) : 17490, 17844
. : milestone, 17667,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~7fc7401f51, baseline=1.60.0-SNAPSHOT~1c44c6f9a7
dateFormat X
axisFormat %s
section baseline
no_agent (1.202 ms) : 1190, 1213
. : milestone, 1202,
iast (3.186 ms) : 3144, 3228
. : milestone, 3186,
iast_FULL (5.544 ms) : 5490, 5599
. : milestone, 5544,
iast_GLOBAL (3.431 ms) : 3379, 3483
. : milestone, 3431,
profiling (2.127 ms) : 2106, 2147
. : milestone, 2127,
tracing (1.786 ms) : 1771, 1800
. : milestone, 1786,
section candidate
no_agent (1.189 ms) : 1178, 1200
. : milestone, 1189,
iast (3.126 ms) : 3083, 3168
. : milestone, 3126,
iast_FULL (5.883 ms) : 5823, 5943
. : milestone, 5883,
iast_GLOBAL (3.534 ms) : 3479, 3588
. : milestone, 3534,
profiling (2.141 ms) : 2121, 2161
. : milestone, 2141,
tracing (1.754 ms) : 1740, 1768
. : milestone, 1754,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~7fc7401f51, baseline=1.60.0-SNAPSHOT~1c44c6f9a7
dateFormat X
axisFormat %s
section baseline
no_agent (15.046 s) : 15046000, 15046000
. : milestone, 15046000,
appsec (15.235 s) : 15235000, 15235000
. : milestone, 15235000,
iast (18.057 s) : 18057000, 18057000
. : milestone, 18057000,
iast_GLOBAL (17.74 s) : 17740000, 17740000
. : milestone, 17740000,
profiling (15.478 s) : 15478000, 15478000
. : milestone, 15478000,
tracing (14.622 s) : 14622000, 14622000
. : milestone, 14622000,
section candidate
no_agent (14.937 s) : 14937000, 14937000
. : milestone, 14937000,
appsec (14.984 s) : 14984000, 14984000
. : milestone, 14984000,
iast (19.048 s) : 19048000, 19048000
. : milestone, 19048000,
iast_GLOBAL (17.927 s) : 17927000, 17927000
. : milestone, 17927000,
profiling (14.724 s) : 14724000, 14724000
. : milestone, 14724000,
tracing (14.556 s) : 14556000, 14556000
. : milestone, 14556000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~7fc7401f51, baseline=1.60.0-SNAPSHOT~1c44c6f9a7
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.786 ms) : 3564, 4007
. : milestone, 3786,
iast (2.247 ms) : 2177, 2316
. : milestone, 2247,
iast_GLOBAL (2.297 ms) : 2227, 2366
. : milestone, 2297,
profiling (2.074 ms) : 2020, 2129
. : milestone, 2074,
tracing (2.053 ms) : 1999, 2106
. : milestone, 2053,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.509 ms) : 2455, 2564
. : milestone, 2509,
iast (2.247 ms) : 2177, 2316
. : milestone, 2247,
iast_GLOBAL (2.293 ms) : 2224, 2362
. : milestone, 2293,
profiling (2.071 ms) : 2016, 2126
. : milestone, 2071,
tracing (2.077 ms) : 2023, 2132
. : milestone, 2077,
|
e84a9e2 to
987d87b
Compare
|
@mcculls I updated the PR with a second commit to fix unexpected header injections on current span when interacting with headers. |
987d87b to
7fc7401
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
This PR generalizes muting the tracing for HTTP client calls.
Originally only applied to OkHttp3, it will now be applied to JDK HTTP Client too.
Additionally, it fixes the fact that current active spans are getting injected propagation headers when application access the request headers - independently of the injection mechanism.
Motivation
Start leveraging JDK HTTP client as HTTP client.
Additional Notes
Also does a bit of clean up of the java-net instrumentation (deprecated API, static imports).
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.