Add workflow to prevent new Groovy test files#10730
Open
sarahchen6 wants to merge 4 commits intomasterfrom
Open
Add workflow to prevent new Groovy test files#10730sarahchen6 wants to merge 4 commits intomasterfrom
sarahchen6 wants to merge 4 commits intomasterfrom
Conversation
sarahchen6
force-pushed
the
sarahchen6/workflow-to-enforce-no-groovy
branch
from
b77de38 to
8164b95
Compare
sarahchen6
added
tag: no release notes
sarahchen6
added
tag: override-groovy-enforcement
Contributor
Author
|
We can confirm that adding the |
sarahchen6
added
the
tag: override-groovy-enforcement
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 64 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~9c781e1d5e, baseline=1.61.0-SNAPSHOT~77900be502
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060726
Total [baseline] (8.855 s) : 0, 8854595
Agent [candidate] (1.061 s) : 0, 1060778
Total [candidate] (8.838 s) : 0, 8837765
section iast
Agent [baseline] (1.231 s) : 0, 1231044
Total [baseline] (9.541 s) : 0, 9541204
Agent [candidate] (1.227 s) : 0, 1227299
Total [candidate] (9.581 s) : 0, 9581266
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~9c781e1d5e, baseline=1.61.0-SNAPSHOT~77900be502
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (628.872 ms) : 0, 628872
BytebuddyAgent [candidate] (630.076 ms) : 0, 630076
AgentMeter [baseline] (29.163 ms) : 0, 29163
AgentMeter [candidate] (29.147 ms) : 0, 29147
GlobalTracer [baseline] (257.152 ms) : 0, 257152
GlobalTracer [candidate] (257.547 ms) : 0, 257547
AppSec [baseline] (31.472 ms) : 0, 31472
AppSec [candidate] (31.52 ms) : 0, 31520
Debugger [baseline] (58.776 ms) : 0, 58776
Debugger [candidate] (58.659 ms) : 0, 58659
Remote Config [baseline] (595.308 µs) : 0, 595
Remote Config [candidate] (591.057 µs) : 0, 591
Telemetry [baseline] (8.739 ms) : 0, 8739
Telemetry [candidate] (8.712 ms) : 0, 8712
Flare Poller [baseline] (8.684 ms) : 0, 8684
Flare Poller [candidate] (7.225 ms) : 0, 7225
section iast
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (800.113 ms) : 0, 800113
BytebuddyAgent [candidate] (796.891 ms) : 0, 796891
AgentMeter [baseline] (11.304 ms) : 0, 11304
AgentMeter [candidate] (11.327 ms) : 0, 11327
GlobalTracer [baseline] (247.383 ms) : 0, 247383
GlobalTracer [candidate] (247.586 ms) : 0, 247586
IAST [baseline] (25.234 ms) : 0, 25234
IAST [candidate] (25.151 ms) : 0, 25151
AppSec [baseline] (26.359 ms) : 0, 26359
AppSec [candidate] (26.329 ms) : 0, 26329
Debugger [baseline] (62.743 ms) : 0, 62743
Debugger [candidate] (62.375 ms) : 0, 62375
Remote Config [baseline] (528.225 µs) : 0, 528
Remote Config [candidate] (524.158 µs) : 0, 524
Telemetry [baseline] (15.134 ms) : 0, 15134
Telemetry [candidate] (14.969 ms) : 0, 14969
Flare Poller [baseline] (4.895 ms) : 0, 4895
Flare Poller [candidate] (4.898 ms) : 0, 4898
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~9c781e1d5e, baseline=1.61.0-SNAPSHOT~77900be502
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1067439
Total [baseline] (11.099 s) : 0, 11098819
Agent [candidate] (1.069 s) : 0, 1068634
Total [candidate] (11.079 s) : 0, 11079431
section appsec
Agent [baseline] (1.255 s) : 0, 1254724
Total [baseline] (11.163 s) : 0, 11163163
Agent [candidate] (1.248 s) : 0, 1248066
Total [candidate] (11.253 s) : 0, 11252859
section iast
Agent [baseline] (1.23 s) : 0, 1229560
Total [baseline] (11.405 s) : 0, 11405179
Agent [candidate] (1.229 s) : 0, 1228512
Total [candidate] (11.336 s) : 0, 11335746
section profiling
Agent [baseline] (1.185 s) : 0, 1184505
Total [baseline] (11.067 s) : 0, 11066504
Agent [candidate] (1.183 s) : 0, 1182685
Total [candidate] (11.123 s) : 0, 11122674
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~9c781e1d5e, baseline=1.61.0-SNAPSHOT~77900be502
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (632.557 ms) : 0, 632557
BytebuddyAgent [candidate] (634.666 ms) : 0, 634666
AgentMeter [baseline] (29.321 ms) : 0, 29321
AgentMeter [candidate] (29.424 ms) : 0, 29424
GlobalTracer [baseline] (258.561 ms) : 0, 258561
GlobalTracer [candidate] (259.12 ms) : 0, 259120
AppSec [baseline] (32.014 ms) : 0, 32014
AppSec [candidate] (31.666 ms) : 0, 31666
Debugger [baseline] (60.154 ms) : 0, 60154
Debugger [candidate] (59.702 ms) : 0, 59702
Remote Config [baseline] (598.234 µs) : 0, 598
Remote Config [candidate] (604.696 µs) : 0, 605
Telemetry [baseline] (8.764 ms) : 0, 8764
Telemetry [candidate] (8.759 ms) : 0, 8759
Flare Poller [baseline] (8.132 ms) : 0, 8132
Flare Poller [candidate] (7.34 ms) : 0, 7340
section appsec
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (663.764 ms) : 0, 663764
BytebuddyAgent [candidate] (659.319 ms) : 0, 659319
AgentMeter [baseline] (12.108 ms) : 0, 12108
AgentMeter [candidate] (12.003 ms) : 0, 12003
GlobalTracer [baseline] (259.737 ms) : 0, 259737
GlobalTracer [candidate] (258.789 ms) : 0, 258789
IAST [baseline] (24.14 ms) : 0, 24140
IAST [candidate] (24.044 ms) : 0, 24044
AppSec [baseline] (178.393 ms) : 0, 178393
AppSec [candidate] (177.815 ms) : 0, 177815
Debugger [baseline] (65.696 ms) : 0, 65696
Debugger [candidate] (65.475 ms) : 0, 65475
Remote Config [baseline] (578.876 µs) : 0, 579
Remote Config [candidate] (579.098 µs) : 0, 579
Telemetry [baseline] (9.049 ms) : 0, 9049
Telemetry [candidate] (9.059 ms) : 0, 9059
Flare Poller [baseline] (3.641 ms) : 0, 3641
Flare Poller [candidate] (3.564 ms) : 0, 3564
section iast
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (798.038 ms) : 0, 798038
BytebuddyAgent [candidate] (796.959 ms) : 0, 796959
AgentMeter [baseline] (11.342 ms) : 0, 11342
AgentMeter [candidate] (11.299 ms) : 0, 11299
GlobalTracer [baseline] (247.683 ms) : 0, 247683
GlobalTracer [candidate] (247.684 ms) : 0, 247684
IAST [baseline] (25.175 ms) : 0, 25175
IAST [candidate] (25.235 ms) : 0, 25235
AppSec [baseline] (26.348 ms) : 0, 26348
AppSec [candidate] (27.252 ms) : 0, 27252
Debugger [baseline] (63.53 ms) : 0, 63530
Debugger [candidate] (62.66 ms) : 0, 62660
Remote Config [baseline] (535.438 µs) : 0, 535
Remote Config [candidate] (541.223 µs) : 0, 541
Telemetry [baseline] (14.83 ms) : 0, 14830
Telemetry [candidate] (14.813 ms) : 0, 14813
Flare Poller [baseline] (4.853 ms) : 0, 4853
Flare Poller [candidate] (4.896 ms) : 0, 4896
section profiling
crashtracking [baseline] (1.167 ms) : 0, 1167
crashtracking [candidate] (1.164 ms) : 0, 1164
BytebuddyAgent [baseline] (684.995 ms) : 0, 684995
BytebuddyAgent [candidate] (682.836 ms) : 0, 682836
AgentMeter [baseline] (8.571 ms) : 0, 8571
AgentMeter [candidate] (8.532 ms) : 0, 8532
GlobalTracer [baseline] (215.273 ms) : 0, 215273
GlobalTracer [candidate] (215.343 ms) : 0, 215343
AppSec [baseline] (31.95 ms) : 0, 31950
AppSec [candidate] (31.896 ms) : 0, 31896
Debugger [baseline] (63.514 ms) : 0, 63514
Debugger [candidate] (63.586 ms) : 0, 63586
Remote Config [baseline] (584.307 µs) : 0, 584
Remote Config [candidate] (580.104 µs) : 0, 580
Telemetry [baseline] (9.836 ms) : 0, 9836
Telemetry [candidate] (9.051 ms) : 0, 9051
Flare Poller [baseline] (3.52 ms) : 0, 3520
Flare Poller [candidate] (4.301 ms) : 0, 4301
ProfilingAgent [baseline] (94.299 ms) : 0, 94299
ProfilingAgent [candidate] (94.65 ms) : 0, 94650
Profiling [baseline] (94.873 ms) : 0, 94873
Profiling [candidate] (95.222 ms) : 0, 95222
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~9c781e1d5e, baseline=1.61.0-SNAPSHOT~77900be502
dateFormat X
axisFormat %s
section baseline
no_agent (19.55 ms) : 19347, 19752
. : milestone, 19550,
appsec (18.631 ms) : 18443, 18819
. : milestone, 18631,
code_origins (17.968 ms) : 17790, 18147
. : milestone, 17968,
iast (17.771 ms) : 17594, 17948
. : milestone, 17771,
profiling (19.414 ms) : 19218, 19610
. : milestone, 19414,
tracing (17.926 ms) : 17750, 18103
. : milestone, 17926,
section candidate
no_agent (19.532 ms) : 19332, 19733
. : milestone, 19532,
appsec (19.617 ms) : 19413, 19821
. : milestone, 19617,
code_origins (17.651 ms) : 17476, 17826
. : milestone, 17651,
iast (18.298 ms) : 18114, 18482
. : milestone, 18298,
profiling (18.925 ms) : 18737, 19114
. : milestone, 18925,
tracing (17.83 ms) : 17650, 18009
. : milestone, 17830,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~9c781e1d5e, baseline=1.61.0-SNAPSHOT~77900be502
dateFormat X
axisFormat %s
section baseline
no_agent (1.19 ms) : 1178, 1202
. : milestone, 1190,
iast (3.301 ms) : 3259, 3343
. : milestone, 3301,
iast_FULL (6.056 ms) : 5994, 6118
. : milestone, 6056,
iast_GLOBAL (3.532 ms) : 3481, 3584
. : milestone, 3532,
profiling (2.259 ms) : 2236, 2281
. : milestone, 2259,
tracing (1.788 ms) : 1772, 1803
. : milestone, 1788,
section candidate
no_agent (1.181 ms) : 1170, 1193
. : milestone, 1181,
iast (3.078 ms) : 3040, 3117
. : milestone, 3078,
iast_FULL (5.905 ms) : 5846, 5964
. : milestone, 5905,
iast_GLOBAL (3.637 ms) : 3581, 3693
. : milestone, 3637,
profiling (1.914 ms) : 1898, 1930
. : milestone, 1914,
tracing (1.875 ms) : 1859, 1891
. : milestone, 1875,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~9c781e1d5e, baseline=1.61.0-SNAPSHOT~77900be502
dateFormat X
axisFormat %s
section baseline
no_agent (15.61 s) : 15610000, 15610000
. : milestone, 15610000,
appsec (14.905 s) : 14905000, 14905000
. : milestone, 14905000,
iast (17.993 s) : 17993000, 17993000
. : milestone, 17993000,
iast_GLOBAL (17.735 s) : 17735000, 17735000
. : milestone, 17735000,
profiling (14.961 s) : 14961000, 14961000
. : milestone, 14961000,
tracing (14.968 s) : 14968000, 14968000
. : milestone, 14968000,
section candidate
no_agent (15.444 s) : 15444000, 15444000
. : milestone, 15444000,
appsec (14.838 s) : 14838000, 14838000
. : milestone, 14838000,
iast (18.411 s) : 18411000, 18411000
. : milestone, 18411000,
iast_GLOBAL (17.661 s) : 17661000, 17661000
. : milestone, 17661000,
profiling (14.775 s) : 14775000, 14775000
. : milestone, 14775000,
tracing (15.26 s) : 15260000, 15260000
. : milestone, 15260000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~9c781e1d5e, baseline=1.61.0-SNAPSHOT~77900be502
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (3.802 ms) : 3581, 4023
. : milestone, 3802,
iast (2.257 ms) : 2187, 2326
. : milestone, 2257,
iast_GLOBAL (2.299 ms) : 2230, 2369
. : milestone, 2299,
profiling (2.073 ms) : 2019, 2128
. : milestone, 2073,
tracing (2.055 ms) : 2001, 2108
. : milestone, 2055,
section candidate
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (3.798 ms) : 3577, 4018
. : milestone, 3798,
iast (2.248 ms) : 2179, 2318
. : milestone, 2248,
iast_GLOBAL (2.298 ms) : 2228, 2368
. : milestone, 2298,
profiling (2.518 ms) : 2300, 2735
. : milestone, 2518,
tracing (2.077 ms) : 2023, 2132
. : milestone, 2077,
|
Contributor
PerfectSlayer
left a comment
PerfectSlayer
left a comment
There was a problem hiding this comment.
👏 praise: Thanks for taking care of it!
I left few comments, especially around the migrated-modules.txt on master.
❔ question: I saw there was 2 comments, one for warnings, one for regressions.
I wonder if it would not be easier to have a single one? You can generate its content (both warnings and regression) and:
- add/update the unique comment if there is one or the other + fail the check
- delete the unique comment if present otherwise
How does it sound?
🎯 suggestion: Additionally, you can update the skill to ask to update the migrated-modules.txt file once module migration is complete.
Contributor
|
@codex review |
Contributor
|
I asked additional review from Codex as I'm not well versed in reviewing Node JS code from Yaml files 😅 |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8164b95343
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Author
It makes more sense IMO to separate the logic of the comments -- in particular, the regressions comment fails the workflow and needs to be addressed / deleted, whereas the warnings comment is just a recommendation. With separation, each comment can be individually updated instead of having to check the combined content. This may make the PR initially more cluttered with two comments, but at least one of them will be deleted eventually. 🤔 |
sarahchen6
added
tag: override-groovy-enforcement
PerfectSlayer
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Add a new Github Action workflow that prevents new Groovy test files from creation. Specifically, this workflow:
.github/migrated-modules.txt. The expectation is that all fully-migrated modules are listed in.github/migrated-modules.txt.dd-smoke-testsanddd-java-agent/instrumentationsare excluded from this.override-groovy-enforcementlabel to this PR.Motivation
During our broader effort to migrate Groovy test files to Java, we should not introduce further regressions. Since
dd-smoke-testsanddd-java-agent/instrumentationsare latter priorities, we excluded them from these checks for now.Additional Notes
The workflow needs to be merged to
masterbefore testing.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.