Scheduler: refactor core files (TS) - Part 3#33883
Merged
bit-byte0 merged 4 commits intoJun 8, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the internal Scheduler table creator module by renaming m_table_creator.ts to table_creator.ts and introducing stronger TypeScript typing to support stricter ESLint/TS rules, with corresponding import updates across Scheduler workspaces and tests.
Changes:
- Renamed the internal Scheduler table creator module and updated consumer imports.
- Added TypeScript interfaces/type aliases for table/group row generation logic.
- Adjusted Agenda group-header customization typings to align with the new table creator API.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/tableCreator.tests.js | Updates test import to the renamed internal module. |
| packages/devextreme/js/__internal/scheduler/workspaces/timeline.ts | Switches workspace import to table_creator. |
| packages/devextreme/js/__internal/scheduler/workspaces/m_work_space.ts | Switches workspace import to table_creator. |
| packages/devextreme/js/__internal/scheduler/workspaces/agenda.ts | Switches import to table_creator and aligns groupCellCustomContent parameter types with the new TS typing. |
| packages/devextreme/js/__internal/scheduler/table_creator.ts | New typed implementation replacing m_table_creator.ts. |
| packages/devextreme/js/__internal/scheduler/m_table_creator.ts | Removes the old module implementation. |
bit-byte0
force-pushed
the
refactor/scheduler-core-ts-part-3
branch
from
4ad7819 to
c9e76bf
Compare
bit-byte0
force-pushed
the
refactor/scheduler-core-ts-part-3
branch
from
c9e76bf to
47f44e6
Compare
Tucchhaa
previously approved these changes
Jun 8, 2026
bit-byte0
force-pushed
the
refactor/scheduler-core-ts-part-3
branch
from
02cc02e to
1d8f0ba
Compare
Tucchhaa
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Renamed
m_table_creator.ts→table_creator.tsand added TypeScript types to enable strict ESLint/TS rules + updated all 4 consumer importsHow
Added interfaces (
CellData,MakeTableOptions,GroupCssClasses,GroupedTableConfig,TableCell,GroupCell) and type aliases (TemplateCallback,TableRow,GroupCellRow). Fixed depth issues with optional chaining, conditional spread, andObject.assign. Eliminated all pre-existingeslint-disablecomments