Added I23ZoomController to account for the differing PV names#2097
Open
adaudon wants to merge 3 commits into
Open
Added I23ZoomController to account for the differing PV names#2097adaudon wants to merge 3 commits into
adaudon wants to merge 3 commits into
Conversation
… zoom controller on I23.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2097 +/- ##
=======================================
Coverage 99.15% 99.15%
=======================================
Files 345 345
Lines 13472 13482 +10
=======================================
+ Hits 13358 13368 +10
Misses 114 114 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
added 2 commits
June 17, 2026 15:34
DominicOram
requested changes
Jun 17, 2026
DominicOram
left a comment
Contributor
There was a problem hiding this comment.
Thanks, I think that rather than make a new device it might be better to just change the ZoomController so you can specify the suffix for the percentage/level. That's what we've done in other places where they have been different. I would also suggest you ask controls to make an alias for CAM:MP:SELECT -> ZOOM:MP:SELECT, we can then reuse the device with no changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other mx-beamlines use a different PV name for zoom. Created a ZoomController specific to I23.
Fixes DiamondLightSource/mx-bluesky#1771
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}