Skip to content

Added I23ZoomController to account for the differing PV names#2097

Open
adaudon wants to merge 3 commits into
mainfrom
1706-I23Blueapisetup
Open

Added I23ZoomController to account for the differing PV names#2097
adaudon wants to merge 3 commits into
mainfrom
1706-I23Blueapisetup

Conversation

@adaudon

@adaudon adaudon commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Other mx-beamlines use a different PV name for zoom. Created a ZoomController specific to I23.

Fixes DiamondLightSource/mx-bluesky#1771

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@adaudon adaudon requested a review from a team as a code owner June 17, 2026 14:27
@adaudon adaudon added the i23 label Jun 17, 2026
@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.15%. Comparing base (641e0a4) to head (d8a2ed9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2097   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files         345      345           
  Lines       13472    13482   +10     
=======================================
+ Hits        13358    13368   +10     
  Misses        114      114           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Tamoor Shahid added 2 commits June 17, 2026 15:34

@DominicOram DominicOram left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think that rather than make a new device it might be better to just change the ZoomController so you can specify the suffix for the percentage/level. That's what we've done in other places where they have been different. I would also suggest you ask controls to make an alias for CAM:MP:SELECT -> ZOOM:MP:SELECT, we can then reuse the device with no changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change OAV Zoom PVs for I23

2 participants